Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bring back MQF #800

Closed
wants to merge 1 commit into from
Closed

[WIP] bring back MQF #800

wants to merge 1 commit into from

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Dec 17, 2019

I commented out the MQF parts for the #424 and #773 merges.

Since #773 also added CI checks to verify

  1. if the rust crate is publishable (long story short: a crate can only be published if all dependencies are also in crates.io), and
  2. if the crate build on macOS and Windows

The MQF code was failing because 2 is not working. Opening this as a standing PR while fixes are pushed to the MQF repo to make this all work.

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

Merging #800 into master will decrease coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
- Coverage   79.59%   79.35%   -0.25%     
==========================================
  Files          45       46       +1     
  Lines        6588     6684      +96     
  Branches      454      467      +13     
==========================================
+ Hits         5244     5304      +60     
- Misses       1043     1069      +26     
- Partials      301      311      +10
Impacted Files Coverage Δ
src/index/mod.rs 56.3% <ø> (ø) ⬆️
src/index/sbt/mod.rs 60.26% <ø> (ø) ⬆️
src/index/sbt/mhmt.rs 60.63% <100%> (ø)
src/lib.rs 60.89% <0%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3febb3f...dfae20b. Read the comment docs.

@luizirber luizirber mentioned this pull request Dec 17, 2019
8 tasks
@luizirber luizirber added the rust label Dec 17, 2019
@luizirber luizirber closed this Dec 29, 2019
@luizirber
Copy link
Member Author

Punted for #812

@luizirber luizirber deleted the rust/uncomment_mqf branch December 29, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant