MRG: index should error out if no sigs to index #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be good to track down why #197 didn't fix it? :) |
ctb
approved these changes
Mar 7, 2024
|
I think I'll merge this and then leave the larger changes now discussed in #207 to a different PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexhas been failing silently if there are no signatures to index by producing a rocksdb database that is just empty of sigs. It's been quite frustrating with issues arising from protein databases with pre-0.9.0 (aka incorrect) manifests :).This PR changes
indexto Error out if there are no sigs to index.I thought this had been handled as per #207, but regardless, it is fixed here.