MRG: add error-exit in fastmultigather against rocksdb for failed gather #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue noted in #390 (comment), where if a RocksDB cannot load a sketch from external FSStorage,
fastmultigather
outputs an error message, but doesn't actually error exit.With this PR, a clear error message is printed. However, we don't quit out of the fastmultigather early; that seemed like a harder fix :).