Customize logging destination #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o customize_logging_dest
rshade
approved these changes
Mar 27, 2017
|
|
|
Thanks for the contribution! We could do with a simple test to see if this puts the right config on disk please and we'll ship the cookbook as soon as that's done. |
|
I would happily but honestly right now I don't really understand where to put the tests. Your dokken file references inspec but that doesn't seem to be used. you have serverspec and bats, and well honestly I am confused about how this all comes together. |
|
No problem, if you jump onto the sous-chefs channel on the chef community slack (http://community-slack.chef.io/) we'll give you a hand understanding it. It might be time to add a testing.md for the dokken stuff. However regarding inspec and bats, that's another reason why we are doing the rewrite. |
gmccue
added a commit
to ecosia/haproxy
that referenced
this pull request
Apr 18, 2017
* upstream/master: (145 commits) readme update (sous-chefs#185) release update (sous-chefs#183) Fix bug introduced in sous-chefs#174 (sous-chefs#182) fixing changelog links (sous-chefs#181) updating for release, and fixing sudo (sous-chefs#180) Customize logging destination (sous-chefs#178) updating to use bats/serverspec (sous-chefs#179) Chef 13 (sous-chefs#176) Update kitchen config Cookstyle fix Fix contributing doc typo Update Kitchen config and remove 12.04 testing Test with Delivery local Add github templates Added capacity to understand multiple address and ports with array for 'bind' attribute of haproxy_lb resource chef_version requires Chef >= 12.6.0. Placeholder changelog. Allow server startup from app_lb recipe. adding the rest of the source adding source-ubuntu ...
rshade
added a commit
that referenced
this pull request
Apr 18, 2017
* Allow server startup from app_lb recipe. * Placeholder changelog. * chef_version requires Chef >= 12.6.0. * Added capacity to understand multiple address and ports with array for 'bind' attribute of haproxy_lb resource * Add github templates Signed-off-by: Tim Smith <tsmith@chef.io> * Test with Delivery local Signed-off-by: Tim Smith <tsmith@chef.io> * Update Kitchen config and remove 12.04 testing Signed-off-by: Tim Smith <tsmith@chef.io> * Fix contributing doc typo Signed-off-by: Tim Smith <tsmith@chef.io> * Cookstyle fix Signed-off-by: Tim Smith <tsmith@chef.io> * Update kitchen config Signed-off-by: Tim Smith <tsmith@chef.io> * Chef 13 (#176) * adding provisioner erorr for Chef-13 * Use parameters instead of reserved word, params * Update cookbook for Chef-13 (Closes #175) * updating to use bats/serverspec (#179) * updating to use bats/serverspec * setting verifier path * Customize logging destination (#178) * Allow global logging to be customized * Modify attributes * Fixx attributes, again * And again * Fix rubocop error * Add in serverspec testing * Add in serverspec testing * updating for release, and fixing sudo (#180) * updating for release, and fixing sudo * fixing source path * fixing changelog links (#181) * Fix bug introduced in #174 (#182) This fixes a bug that was introduced in #174 which doesn't honor the fact if the bind parameter is nil don't include any bind line. In our case, we put in the bind keyword in the parameters parameter so this added two bind statements and made haproxy unhappy. It looks like this was a copypasta originally as this was included in the prior code. * release update (#183) * readme update (#185) * removing extras * fixing extras * adding in two more fixes
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows logging to be fully configurable.
Issues Resolved
None
Contribution Check List