Custom resource with master #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow server startup from app_lb recipe.
chef_version requires Chef >= 12.6.0.
…r 'bind' attribute of haproxy_lb resource
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Signed-off-by: Tim Smith <tsmith@chef.io>
Testing updates
Multiple addresses and ports on listener and frontend
* updating to use bats/serverspec * setting verifier path
* Allow global logging to be customized * Modify attributes * Fixx attributes, again * And again * Fix rubocop error * Add in serverspec testing * Add in serverspec testing
* updating for release, and fixing sudo * fixing source path
This fixes a bug that was introduced in #174 which doesn't honor the fact if the bind parameter is nil don't include any bind line. In our case, we put in the bind keyword in the parameters parameter so this added two bind statements and made haproxy unhappy. It looks like this was a copypasta originally as this was included in the prior code.
damacus
pushed a commit
that referenced
this pull request
Apr 18, 2017
* adding global attributes, removing them from attributes/default.rb, and updating package_name/version in haproxy.rb * adding debug_option in place of quiet, and adding enable_stats_socket * adding in default properties * moving source install to resource for consistency * Reorder/tidy up metadata Remove rubocop yaml file * Make sure we have Chef 13 compatibility * Remove old tests that are now invalid (bats, serverspec etc) * Move node attributes to properties * Move attributes to properties * Switch to delivery, ignore FC016 * Move the test cookbook to appease chefSpec * Add a few tests * Spell integration correctly, update test platforms, * Make make make it work * Fix prefix for debians lazy path * Add global config * Restart the correct services * Add default and global configs & installs correctly Add example configs Some integration specs for configs Add further stubbed out, frontend, backend, listener configs. Getting edit resource to bend to my will a bit further :) * Add frontend * only populate arrays/hashes if there are values to be added * Update gemfile, remove things we don't use anymore * Apply integration tests correctly. * Add listen section * Remove 12.04 (EOL on the 28th of April) * edit_resource to stop resource cloning * Original template should do nothing No tuning on by default * Chef 12.5 compatability. * haproxy --> haproxy_install custom resource * Move unit files and remove matchers.rb * Tidy up test files * Docker --> dokken * put service definition in root context and outside source/package block * Remove foodcritic warnings now @tas50 has fixed foodcritic * Tidy up dokken config, remove foodcritic file, use simple spec test * Tidy up travis.yml * replace tabs with spaces and fix broken tests * Fix ERB template * Remove rsyslog * define acls before use_backend in config * Custom resource with master (#188) * Allow server startup from app_lb recipe. * Placeholder changelog. * chef_version requires Chef >= 12.6.0. * Added capacity to understand multiple address and ports with array for 'bind' attribute of haproxy_lb resource * Add github templates * Test with Delivery local * Update Kitchen config and remove 12.04 testing * Fix contributing doc typo * Cookstyle fix * Update kitchen config * Chef 13 compatability (#176) * updating for release, and fixing sudo (#180) * updating for release, and fixing sudo * fixing source path * fixing changelog links (#181) * Fix bug introduced in #174 (#182) This fixes a bug that was introduced in #174 which doesn't honor the fact if the bind parameter is nil don't include any bind line. In our case, we put in the bind keyword in the parameters parameter so this added two bind statements and made haproxy unhappy. It looks like this was a copypasta originally as this was included in the prior code. * Closes #151, #111, * Closes #159 ACLs are a Hash/Array inside a backends & frontends * Closes #148 we no longer use Chef Search. * Closes #58 as we have a clean way of defining backends.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any existing issues this PR resolves]
Contribution Check List