Bug in yum.conf defaults affecting CentOS 5

[ice799]

Hi:

The default value of /var/cache/yum/$basearch/$releasever in ./attributes/main.rb does not actually have $basearch and $releasever substituted with their values on CentOS 5:

[vagrant@default-centos-510 $releasever]$ pwd
/var/cache/yum/$basearch/$releasever
[vagrant@default-centos-510 $releasever]$ ls
base  epel  extras  updates

Which is not technically an invalid path, but it is a bit ugly and has some interesting side effects.

If:

• a repository is installed without using the yum cookbook (via a noarch rpm, which is a common way to install repo configs, or just directly as a file managed by chef in to /etc/yum.repos.d/)
• the repository has a GPG key for either repository metadata or rpm signature checking
• a repository is installed using the yum cookbook AFTER the above happens

Then:

• the GPG keys will appear to have failed being imported

because the gpg keys are written to the cachedir, then the cachedir is overwritten by chef to be "/var/cache/yum/$basearch/$releasever", and so yum can't find keys written to the old cachedir.

Anyone using CentOS 6 or CentOS 7 wouldn't be affected because:

• the default path on those systems is /var/cache/yum/$basearch/$releasever
• the substitution actually works there.
• 99.999...9% of people never touch /var/cache/yum/$basearch/$releasever so even when yum.conf gets overwritten by chef, it is overwritten to the default value where all the directories and keys and stuff already are.

On CentOS 5, the default path is: /var/cache/yum.

I'd suggest changing the default path to be /var/cache/yum in the yum cookbook for CentOS 5 and leaving the default path unchanged for CentOS 6 and 7 as it works fine as is.

[jtimberman]

I believe that PR #100 resolves this, it adds the missing cachedir option. Would you please confirm on your system?

Thanks!

[jtimberman]

PR #101 also resolves this, but completely refactors the recipe. It will dynamically walk node['yum']['main'] and send each key as an attribute to the resource with the value it's set to, if set.

[cheeseplus]

I can confirm that PR #101 fixes my issue on riak-cs-chef-cookbook for CentOS 5. 👍 and many thanks to @ice799 for digging into this one.

[someara]

Fix Merged in bc7f0ee. Released as 3.4.0