Dynamically generate the new_resource attributes #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #99 came up because an attribute for the `yum_globalconfig` was left out - the cachedir. This commit updates the recipe to dynamically walk the `node['yum']['main']` attributes and send each one with its value to the new resource. This assures that all attributes defined are passed into the configuration. This *can* lead to an error if a user adds an attribute incorrectly. That seems unlikely, though. I hope.
|
This supersedes #100 (and has a merge conflict with that PR), and also will fix #99. I opened this PR separately, as it may be preferable to preserve the recipe with all the resource's attributes as it stands. If that is the case, merge #100 (to resolve #99), and close this PR. Otherwise, do the opposite 🍨. |
|
Merged. Released as 3.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #99 came up because an attribute for the
yum_globalconfigwas left out - the cachedir. This commit updates the recipe to dynamically walk thenode['yum']['main']attributes and send each one with its value to the new resource. This assures that all attributes defined are passed into the configuration.This can lead to an error if a user adds an attribute incorrectly. That seems unlikely, though. I hope.