-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add TinyInt / i8 type #190
Conversation
@Dustin-Ray, I have a question regarding tests: There are some tests in codebase in which: either one of integer type is tested against any other non-integer type. should i add a similar test with |
@Dustin-Ray changes can be reviewed now |
e57e1ad
to
4ab705f
Compare
In general yes, we require thorough tests to cover every case possible. The tests you linked to are surrounding |
Please check that the CI passes locally, check, tests, and clippy are currently failing. Ping me when these are fixed and I will run CI again |
|
we have custom ci commands, you need to run:
|
73df454
to
24b60d6
Compare
24b60d6
to
f46cc4b
Compare
ran above mentioned commands, they are passing. added as many tests as possible, let me know if i missed any @Dustin-Ray |
great thanks, will review asap |
@iajoiner let us know what you think then we can maybe wrap this one up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
You will need to resolve the branch conflicts with main. Once that is done, I'll need to reapprove.
9a25a18
done @JayWhite2357 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
🎉 This PR is included in version 0.28.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
@JayWhite2357: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment. |
/closes #154
/claim #154
Rationale for this change
We already have
SmallInt / i16
,Int / i32
, andBigInt / i64
data types supported. Adding an additionalTinyInt / i8
data type would be helpful to some users and would additionally have (minor) performance benefits with those columns.What changes are included in this PR?
Added a TinyInt variant to the various Column enum types.
Added a branch for handling TinyInt everywhere that SmallInt, Int, and BigInt are handled.
Are these changes tested?
Added unit tests covering the additional code.