Skip to content

Commit

Permalink
Backport PR #2173 on branch v3.4.x (IPython 8.13+ is Python 3.9 only) (
Browse files Browse the repository at this point in the history
…#2175)

* Backport PR #2173: IPython 8.13+ is Python 3.9 only

* No more warning in test_slice

* Actually just ignore the warning

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
  • Loading branch information
meeseeksmachine and pllim authored Apr 28, 2023
1 parent 3a67302 commit 3fd911b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 4 additions & 1 deletion jdaviz/configs/cubeviz/plugins/slice/tests/test_slice.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import warnings

import pytest
import numpy as np

Expand Down Expand Up @@ -56,7 +58,8 @@ def test_slice(cubeviz_helper, spectrum1d_cube):
# test setting a static 2d image to the "watched" flux viewer to make sure it disconnects
mm = app.get_tray_item_from_name('cubeviz-moment-maps')
mm.add_to_viewer_selected = 'flux-viewer'
with pytest.warns(UserWarning, match='No observer defined on WCS'):
with warnings.catch_warnings():
warnings.filterwarnings('ignore', message=r'.*No observer defined on WCS.*')
mm.vue_calculate_moment()

assert len(sl._watched_viewers) == 2
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ install_requires =
glue-core>=1.6.0,!=v1.9.0
glue-jupyter>=0.15.0
echo>=0.5.0
ipython<8.13;python_version=='3.8'
ipykernel>=6.19.4
ipyvue>=1.6
ipyvuetify>=1.7.0
Expand Down

0 comments on commit 3fd911b

Please sign in to comment.