Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPython 8.13+ is Python 3.9 only #2173

Merged
merged 1 commit into from
Apr 28, 2023
Merged

IPython 8.13+ is Python 3.9 only #2173

merged 1 commit into from
Apr 28, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 28, 2023

Description

This pull request is to fix CI.

@pllim pllim added testing 🔥 Critical trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤backport-v3.4.x on-merge: backport to v3.4.x labels Apr 28, 2023
@pllim pllim added this to the 3.4.1 milestone Apr 28, 2023
@pllim pllim mentioned this pull request Apr 28, 2023
Merged
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0c513d4) 91.49% compared to head (9245afc) 91.49%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2173   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         147      147           
  Lines       16149    16149           
=======================================
  Hits        14776    14776           
  Misses       1373     1373

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

kecnry
kecnry approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to do the trick - CI is green!

@pllim pllim marked this pull request as ready for review April 28, 2023 14:18
@pllim pllim merged commit aec6ed1 into spacetelescope:main Apr 28, 2023
@pllim pllim deleted the pin-ipython-py38 branch April 28, 2023 14:19
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 28, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Apr 28, 2023
@pllim @meeseeksmachine
Backport PR spacetelescope#2173: IPython 8.13+ is Python 3.9 only
584fe8e
@pllim pllim mentioned this pull request Apr 28, 2023
Merged
9 tasks
pllim added a commit that referenced this pull request Apr 28, 2023
@meeseeksmachine @pllim
Backport PR #2173 on branch v3.4.x (IPython 8.13+ is Python 3.9 only) (…
3fd911b 
…#2175)

* Backport PR #2173: IPython 8.13+ is Python 3.9 only

* No more warning in test_slice

* Actually just ignore the warning

---------

Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kecnry kecnry kecnry approved these changes

@duytnguyendtn duytnguyendtn Awaiting requested review from duytnguyendtn

@rosteen rosteen Awaiting requested review from rosteen rosteen is a code owner

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 is a code owner

Assignees
No one assigned
Labels
🔥 Critical no-changelog-entry-needed changelog bot directive testing trivial Only needs one approval instead of two 💤backport-v3.4.x on-merge: backport to v3.4.x
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@pllim @kecnry