-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merges web kernel framework with mast html page #19
Conversation
Great job. Some immediate issues that jump out at me:
We want to make the app as separable as possible, meaning it should only end up being a single access point -- the I'm going to try and rearrange this. |
Ok, thanks for taking a look. Comments on your comments
But please feel free to do what you need to do to get things working for the demo. |
You're absolutely correct: this is more than sufficient for the demo and shows off exactly what we're after -- no doubt. I just mean that we're not going to be able to merge this into
For now, it's fine, because the mast web app isn't using cubeviz/mosviz directly. But when that time comes, viewers should be removed/added through the application, without destroying the entire rendered widget. E.g. we already have the ability in cubeviz to add more viewers, and in the future, the option to remove a viewer, without messing with the entire state of the app. Does that make a bit more sense? |
@havok2063, generally is this ready for merging? If so, could you rebase and fix the conflict? |
This cannot be merged since it changes fundamental workings of the web interface for use in the standalone web app and the electron app. This was only for demonstration purposes for the communication between a "mast" front-end and the running jupyter kernel. @havok2063 is working on a new implementation using the mast microservice to host an independent mast site with the app embedded. |
This PR has now been deprecated and no longer needs to be merged. The majority of this work has been separated out into a standalone ASB web server, in a grit.stsci.edu repo. The work in the new repo, based off this one, effectively addresses #12 (JIRA 86). Looking at the JIRA issues, I think it resolves issues 60, 61, 62 albeit in a hacky way, 64, 65. |
…n-updates-jt Some more functionality tweaks
This PR addresses #12 and is based off of Nick's #7 PR. This loads a glue image viewer of the manga cube into a div on the html page and includes an html table with pre-populated content.
The original three cases to explore from #12 were
Current Status
which suggests a possible type/format mismatch. The error roughly occurs in