Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPyWidgets on standalone webpage + electron #7

Merged
merged 27 commits into from
Jun 13, 2019

Conversation

nmearl
Copy link
Contributor

@nmearl nmearl commented May 16, 2019

This PR demonstrates rendering ipywidgets on a standalone webpage as well as embedded in an electron app.

Currently, there are issues with displaying bqplot widgets -- this has to do with the custom jupyter-astroimage buried within the installation that is not registered with the node package manager on installation. The jupyter-astroimage package is not available on the npm registry and so currently is not identified when rendering on the page.

Currently attempting to work around this issue by manually linking the package as a local dependency.

@brechmos-stsci
Copy link
Contributor

The bqplot stuff is super important for all this. Do you think you will get it working today?

@havok2063
Copy link
Collaborator

I'm actually having the same issues trying to get any bqplot stuff or widget to display in the web page. I get a bunch of errors regarding rendering children elements. I even tried stripping it down to a barebones HBox widget and couldn't get it working.

@nmearl
Copy link
Contributor Author

nmearl commented May 16, 2019

It's no longer an issue with bqplot, as I can display a raw bqplot just fine. I think it has to do with the glue implementation and its use in your cubeviz hack.

@havok2063
Copy link
Collaborator

havok2063 commented May 16, 2019

I still have issues with the standard bqplot. I pulled your most recent changes and this is what I see. The console indicates issues with container heights.

Screen Shot 2019-05-16 at 2 09 59 PM

@nmearl
Copy link
Contributor Author

nmearl commented May 16, 2019

This is a css issue. Try with the latest push.

@brechmos-stsci
Copy link
Contributor

Could you rebase? I was just going to ck it, but I think it is behind a bit.

@nmearl
Copy link
Contributor Author

nmearl commented May 20, 2019

Everything shows that it's up-to-date with master. Could you also give me write access to this repo?

@brechmos-stsci
Copy link
Contributor

@eteq could you give Nick access? I don't believe I have the ability to give access to others (no Settings).

@stscijgbot
Copy link

This ticket is now being tracked at DATJPP-91

@nmearl
Copy link
Contributor Author

nmearl commented Jun 3, 2019

@brechmos-stsci Since we already have several devs able to successfully install and run the web/desktop app, I think it's best to have you review based on your experience with the raw install instructions. I'd encourage you to write down the specific issues you're having here as well as the results of any extra debugging instructions.

@nmearl nmearl requested a review from javerbukh June 7, 2019 13:57
@brechmos-stsci
Copy link
Contributor

@nmearl is this branch ready for merge? I believe one person has already installed and run this... I can still go through and do a test install.

@nmearl
Copy link
Contributor Author

nmearl commented Jun 13, 2019

This is ready for merging. Cami was successfully able to install and run the web app and electron app locally. @javerbukh intended to attempt to install as well in an effort to review the PR. If Cami is sufficient, this can be merged now.

@brechmos-stsci brechmos-stsci merged commit 82442c5 into spacetelescope:master Jun 13, 2019
javerbukh pushed a commit that referenced this pull request Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants