Display units (unit conversion refactor)

[kecnry]

Description

This pull request compiles all the efforts in the unit conversion refactor to support display units and will remain in draft mode until all those individual efforts are merged into the development branch. Until then, this can serve as a thread to track items that need to be done/tested before eventual merge into main.

Incremental PRs:

• Glue unit conversion in Specviz #2048
• Display units line analysis #2128
• Display units support for markers plugin #2130
• display units: cubeviz/slice plugin #2131
• display units: fix failing tests #2132
• Display units: line lists #2148
• Update Subset Tools plugin to use display units #2195
• Fix unit conversion for PluginMarks and y-limits #2215
• Fix ci again #2227
• Display units: model fitting #2216
• reverts removal of call to set_plot_axes when loading data into viewer #2235

Bugs that need fixing upstream before merge:

• subset fails to create after glue display unit changed using spectral equivalency #2125
• axes limits do not update correctly when changing display unit #2126

Needs testing:

• Update pin once glue 1.9 issues for CI are fixed
• Fix all CI tests (display units: fix failing tests #2132)
• Cubeviz components: Display units line analysis #2128 (review) (although likely deferring implementation outside specviz for initial release)
• Cubeviz cube viewer axes labels seem to have reverted (but not caught by CI - should have regression tests added)
• test component selection downstream in lcviz, see Support full round-trip for LightCurve <-> Data lcviz#24 (comment)
• Mosviz cannot load unit conversion: Display units line analysis #2128 (comment) (although likely deferring implementation outside specviz for initial release)

Other TODOs:

• any other attributes (meta, wcs, etc) in core.helpers.ConfigHelper._get_data._handle_display_units
• 2d-spectrum-viewer (specviz2d, mosviz) support or disable plugin (deferring support)
• image viewer support (in mouseover) for cubeviz (deferring support)
• consider renaming plugin (and update docs accordingly)

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[codecov]

Codecov Report

Patch coverage: 90.73% and project coverage change: +3.19 🎉

Comparison is base (ae6d467) 88.48% compared to head (35dfc58) 91.67%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2127      +/-   ##
==========================================
+ Coverage   88.48%   91.67%   +3.19%     
==========================================
  Files          95      148      +53     
  Lines       10540    16752    +6212     
==========================================
+ Hits         9326    15357    +6031     
- Misses       1214     1395     +181     

Impacted Files	Coverage Δ
...s/imviz/plugins/line_profile_xy/line_profile_xy.py	99.00% <ø> (-0.04%)	⬇️
...onfigs/mosviz/plugins/slit_overlay/slit_overlay.py	88.15% <ø> (+17.10%)	⬆️
jdaviz/configs/specviz/plugins/parsers.py	90.80% <ø> (+0.27%)	⬆️
jdaviz/core/tools.py	83.25% <ø> (+1.48%)	⬆️
jdaviz/core/user_api.py	92.45% <ø> (+4.45%)	⬆️
jdaviz/core/validunits.py	82.14% <ø> (-17.86%)	⬇️
jdaviz/models/physical_models.py	91.74% <ø> (+0.07%)	⬆️
jdaviz/utils.py	90.16% <ø> (+0.08%)	⬆️
jdaviz/configs/imviz/tests/test_parser_roman.py	10.00% <10.00%> (ø)
jdaviz/cli.py	20.89% <22.72%> (-1.33%)	⬇️
... and 86 more

... and 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rosteen]

Approved, a few things don't work perfectly in line lists but we were going to defer that to a larger overhaul of line lists.