Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display units: cubeviz/slice plugin #2131

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Apr 5, 2023

Description

This pull request enables the unit conversion plugin in cubeviz and adds support for the slice plugin/indicator. The slice slider is always in order of increasing slice, so will not necessarily correspond to the positive x-direction on the viewer if switched from wavelength > frequency (or vice versa, depending on the original native units).

Screen.Recording.2023-04-05.at.2.13.42.PM.mov

Note that we might want to generalize some of this logic more into the mark's _update_data when adding support for spectral lines as well.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

(we might want to generalize some of this logic more into the mark's _update_data when adding support for spectral lines as well)
Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks like code, and the slider on the spectrum viewer works as expected. Also, great to see the slice plugin was also caught. Changing to Hz also changes the "direction" the plugin slider moves, which I would expect

@pllim
Copy link
Contributor

pllim commented Apr 6, 2023

Does this need glue-core v1.9.0 because we cannot right now, see #2136

@kecnry
Copy link
Member Author

kecnry commented Apr 7, 2023

Does this need glue-core v1.9.0?

Yes, that will likely block the eventual merging of #2127 into main, but should still be able to be tested locally with glue 1.9 or glue-viz/glue#2379.

Copy link
Contributor

@javerbukh javerbukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kecnry kecnry merged commit 0e7f608 into spacetelescope:dev-display-units Apr 10, 2023
@kecnry kecnry deleted the display-units-slice branch April 10, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants