Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: glue-core v1.9.0 is bad glue #2136

Merged
merged 1 commit into from
Apr 6, 2023
Merged

MNT: glue-core v1.9.0 is bad glue #2136

merged 1 commit into from
Apr 6, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 6, 2023

Description

Close #2135

@pllim pllim added this to the 3.4.1 milestone Apr 6, 2023
@pllim pllim added Upstream fix required 🔥 Critical trivial Only needs one approval instead of two no-changelog-entry-needed changelog bot directive 💤backport-v3.4.x on-merge: backport to v3.4.x labels Apr 6, 2023
@pllim pllim mentioned this pull request Apr 6, 2023
Closed
@pllim
Copy link
Contributor Author

pllim commented Apr 6, 2023

The dev job failure signifies that something needs fixing upstream in glue-core.

@pllim pllim marked this pull request as ready for review April 6, 2023 15:50
@rosteen
Copy link
Collaborator

rosteen commented Apr 6, 2023

For some reason I thought we needed 1.9.0 for the unit conversion work, but since the tests aren't failing here I guess not? I'm ok with doing this for now instead of changing the moment test.

@pllim
Copy link
Contributor Author

pllim commented Apr 6, 2023

Re: unit conversion -- good point, but that work is currently in a separate branch, not in main.

@pllim pllim merged commit e7330a0 into spacetelescope:main Apr 6, 2023
@pllim pllim deleted the sticky-situation-glue-v1.9 branch April 6, 2023 19:01
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 6, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Apr 6, 2023
@pllim @meeseeksmachine
Backport PR spacetelescope#2136: MNT: glue-core v1.9.0 is bad glue
9a02b5d
@pllim
Copy link
Contributor Author

pllim commented Apr 6, 2023

Also the != pin does not prevent future releases to be included, so we do not have to undo anything.

This was referenced Apr 6, 2023
Merged
Merged
Merged
Merged
pllim added a commit that referenced this pull request Apr 6, 2023
@pllim
Merge pull request #2137 from meeseeksmachine/auto-backport-of-pr-213…
5bbdf45 
…6-on-v3.4.x

Backport PR #2136 on branch v3.4.x (MNT: glue-core v1.9.0 is bad glue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosteen rosteen rosteen approved these changes

@duytnguyendtn duytnguyendtn Awaiting requested review from duytnguyendtn

@javerbukh javerbukh Awaiting requested review from javerbukh javerbukh is a code owner

@kecnry kecnry Awaiting requested review from kecnry kecnry is a code owner

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

@haticekaratay haticekaratay Awaiting requested review from haticekaratay haticekaratay is a code owner

@cshanahan1 cshanahan1 Awaiting requested review from cshanahan1 cshanahan1 is a code owner

Assignees
No one assigned
Labels
🔥 Critical no-changelog-entry-needed changelog bot directive trivial Only needs one approval instead of two Upstream fix required 💤backport-v3.4.x on-merge: backport to v3.4.x
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@pllim @rosteen