Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for glue 1.19 #2820

Merged
merged 4 commits into from
Apr 19, 2024
Merged

fix support for glue 1.19 #2820

merged 4 commits into from
Apr 19, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Apr 19, 2024

Description

This pull request implements a temporary workaround for glue >= 1.19. This is a revival and slight modification of #2812.

Fixes #2811

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 3.9.1 milestone Apr 19, 2024
@kecnry kecnry added the 💤 backport-v3.9.x on-merge: backport to v3.9.x label Apr 19, 2024
@kecnry kecnry marked this pull request as ready for review April 19, 2024 14:05
@pllim pllim added the trivial Only needs one approval instead of two label Apr 19, 2024
@pllim pllim enabled auto-merge April 19, 2024 14:05
@kecnry kecnry changed the title Glue 1.19 fix support for glue 1.19 Apr 19, 2024
@pllim pllim merged commit 41df897 into spacetelescope:main Apr 19, 2024
17 of 18 checks passed

This comment was marked as resolved.

kecnry added a commit to kecnry/jdaviz that referenced this pull request Apr 19, 2024
@kecnry kecnry mentioned this pull request Apr 19, 2024
kecnry added a commit to kecnry/jdaviz that referenced this pull request Apr 19, 2024
@kecnry kecnry deleted the glue-1.19 branch April 19, 2024 14:29
kecnry added a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial Only needs one approval instead of two 💤 backport-v3.9.x on-merge: backport to v3.9.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make jdaviz unit converter more robust to different data types
2 participants