Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent repeatedly updating previews in specviz2d spectral extraction #2862

Merged
merged 4 commits into from
May 8, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented May 8, 2024

Description

This pull request is an alternative to #2861 to address repeated calls to update spectral extraction previews (especially for "expensive" trace calls) in specviz2d.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added the 💤backport-v3.10.x on-merge: backport to v3.10.x label May 8, 2024
@kecnry kecnry added this to the 3.10.1 milestone May 8, 2024
@github-actions github-actions bot added plugin Label for plugins common to multiple configurations specviz2d labels May 8, 2024
@rosteen
Copy link
Collaborator

rosteen commented May 8, 2024

Looks like this also works, I'm open to merging this instead of mine if you prefer.

@kecnry kecnry marked this pull request as ready for review May 8, 2024 16:43
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.69%. Comparing base (bcea12f) to head (291e0b9).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2862      +/-   ##
==========================================
- Coverage   88.93%   88.69%   -0.24%     
==========================================
  Files         111      111              
  Lines       17165    17111      -54     
==========================================
- Hits        15266    15177      -89     
- Misses       1899     1934      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rosteen rosteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% patch coverage, lowered project coverage? Go home Codecov you're crazy.

Copy link
Contributor

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small diff and seems to do the trick for me!

@pllim pllim merged commit 3418464 into spacetelescope:main May 8, 2024
21 of 22 checks passed

This comment was marked as resolved.

pllim pushed a commit to pllim/jdaviz that referenced this pull request May 8, 2024
…spacetelescope#2862)

* prevent repeatedly updating previews

* changelog

* revert small change when no active step is set

* remove outdated comment

(cherry picked from commit 3418464)
@pllim pllim added the bug Something isn't working label May 8, 2024
rosteen pushed a commit that referenced this pull request May 9, 2024
…n specviz2d spectral extraction) (#2864)

* Prevent repeatedly updating previews in specviz2d spectral extraction (#2862)

* prevent repeatedly updating previews

* changelog

* revert small change when no active step is set

* remove outdated comment

(cherry picked from commit 3418464)

* Fix errors

---------

Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
duytnguyendtn pushed a commit to duytnguyendtn/jdaviz that referenced this pull request Jul 23, 2024
…spacetelescope#2862)

* prevent repeatedly updating previews

* changelog

* revert small change when no active step is set

* remove outdated comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin Label for plugins common to multiple configurations Ready for final review specviz2d 💤backport-v3.10.x on-merge: backport to v3.10.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants