-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent repeatedly updating previews in specviz2d spectral extraction #2862
Conversation
jdaviz/configs/specviz2d/plugins/spectral_extraction/spectral_extraction.py
Outdated
Show resolved
Hide resolved
Looks like this also works, I'm open to merging this instead of mine if you prefer. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2862 +/- ##
==========================================
- Coverage 88.93% 88.69% -0.24%
==========================================
Files 111 111
Lines 17165 17111 -54
==========================================
- Hits 15266 15177 -89
- Misses 1899 1934 +35 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100% patch coverage, lowered project coverage? Go home Codecov you're crazy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small diff and seems to do the trick for me!
This comment was marked as resolved.
This comment was marked as resolved.
…spacetelescope#2862) * prevent repeatedly updating previews * changelog * revert small change when no active step is set * remove outdated comment (cherry picked from commit 3418464)
…n specviz2d spectral extraction) (#2864) * Prevent repeatedly updating previews in specviz2d spectral extraction (#2862) * prevent repeatedly updating previews * changelog * revert small change when no active step is set * remove outdated comment (cherry picked from commit 3418464) * Fix errors --------- Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
…spacetelescope#2862) * prevent repeatedly updating previews * changelog * revert small change when no active step is set * remove outdated comment
Description
This pull request is an alternative to #2861 to address repeated calls to update spectral extraction previews (especially for "expensive" trace calls) in specviz2d.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.