-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport PR 2862 onto v3.10.x (Prevent repeatedly updating previews in specviz2d spectral extraction) #2864
Backport PR 2862 onto v3.10.x (Prevent repeatedly updating previews in specviz2d spectral extraction) #2864
Conversation
…spacetelescope#2862) * prevent repeatedly updating previews * changelog * revert small change when no active step is set * remove outdated comment (cherry picked from commit 3418464)
Does something else need to get backported first? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3.10.x #2864 +/- ##
===========================================
- Coverage 88.93% 88.91% -0.03%
===========================================
Files 111 111
Lines 17165 17163 -2
===========================================
- Hits 15266 15260 -6
- Misses 1899 1903 +4 ☔ View full report in Codecov by Sentry. |
Probably just need the import |
Re: #2864 (comment) I ended up removing it because that code isn't part of the diff I am backporting. |
@rosteen has agreed to review this when he gets the chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested to make sure it behaves the same as on main, looks good.
Thanks for the review! |
Description
This pull request is to manually backport #2862 onto v3.10.x
The diff don't match exactly. I think @kecnry should review.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.