Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-menu: API hints #3274

Merged
merged 11 commits into from
Nov 18, 2024
Merged

data-menu: API hints #3274

merged 11 commits into from
Nov 18, 2024

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 8, 2024

Description

This pull request moves API hint toggles from the plugin to the app-level and implements API hints for the data-menu.

Screen.Recording.2024-11-08.at.3.24.35.PM.mov

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 4.1 milestone Nov 8, 2024
@github-actions github-actions bot added embed Regarding issues with front-end embedding imviz plugin Label for plugins common to multiple configurations labels Nov 8, 2024
@kecnry kecnry force-pushed the dm-api-hints branch 6 times, most recently from 2ff8880 to 90a3fe7 Compare November 11, 2024 15:13
@kecnry kecnry mentioned this pull request Nov 11, 2024
9 tasks
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.81%. Comparing base (6fc4566) to head (7676963).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...viz/configs/default/plugins/data_menu/data_menu.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3274      +/-   ##
==========================================
- Coverage   88.81%   88.81%   -0.01%     
==========================================
  Files         125      125              
  Lines       18960    18968       +8     
==========================================
+ Hits        16839    16846       +7     
- Misses       2121     2122       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry kecnry marked this pull request as ready for review November 14, 2024 15:28
@camipacifici
Copy link
Contributor

I really like it!
The only thing that took me a tiny bit to figure out is the toggle for keeping the hints available for copy/paste. I kept clicking on the lock instead of on the icon and nothing was happening. Then I clicked on the icon. I think it is because the tooltip is also on the lock.

@kecnry
Copy link
Member Author

kecnry commented Nov 15, 2024

@gibsongreen mentioned suggestions for the icon as well, maybe we can get a custom icon from @Jenneh for that down the road. I couldn't find anything off-the-shelf as a single icon that worked well 🫤

Copy link
Contributor

@gibsongreen gibsongreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the code changes look good to me and I really like the hints at the app-level!

I also tried clicking on the lock and agree about the tooltip, but got used to it so I’m for whichever path forward works best.

The other icon suggestion was in a followup effort to possibly update the < > to <API>. As long as the width works out I think it would add a lot of clarity.

@cshanahan1
Copy link
Contributor

This looks good! Is this not complete for all plugins yet? I don't see hints for aperture photometry

@kecnry
Copy link
Member Author

kecnry commented Nov 18, 2024

This PR only brings to the data-menu. Previous PRs have exposed hints for all plugins with public APIs (aperture photometry is not one of those yet).

@kecnry kecnry mentioned this pull request Nov 18, 2024
9 tasks
@kecnry kecnry merged commit f4923fd into spacetelescope:main Nov 18, 2024
25 checks passed
@kecnry kecnry deleted the dm-api-hints branch November 18, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embed Regarding issues with front-end embedding imviz plugin Label for plugins common to multiple configurations Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants