-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Subset Tools Plugin #3293
Rename Subset Tools Plugin #3293
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3293 +/- ##
=======================================
Coverage 88.80% 88.80%
=======================================
Files 125 125
Lines 19009 19019 +10
=======================================
+ Hits 16881 16890 +9
- Misses 2128 2129 +1 ☔ View full report in Codecov by Sentry. |
jdaviz/configs/cubeviz/plugins/moment_maps/tests/test_moment_maps.py
Outdated
Show resolved
Hide resolved
jdaviz/configs/cubeviz/plugins/spectral_extraction/tests/test_spectral_extraction.py
Outdated
Show resolved
Hide resolved
jdaviz/configs/specviz/plugins/line_analysis/tests/test_line_analysis.py
Outdated
Show resolved
Hide resolved
jdaviz/configs/specviz/plugins/line_analysis/tests/test_line_analysis.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few spots left and then this is ready to go, thank you for your patience!
Thank you for catching those. I appreciate having extra eyes on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew! Thanks for the thorough find-and-replaces! Just a few small comments but otherwise LGTM!
#3274 (comment) reminded me... we also need to expose the API hints (but that wasn't in the original scope, so let's make that a quick follow-up). |
Another thing to consider for follow-up - the API path is |
Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you again!
Description
This pull request addresses the following:
subset
- Manages subset selection and creation.combination_mode
- Specifies how subsets are combined (new, replace, or, and, xor, andnot).get_center
- Retrieves the center of the selected subset.set_center
- Updates the center of the selected subset.Fixes #
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.