Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3282 on branch v4.0.x (Add nbclassic dependency to resolve popout error) #3291

Conversation

meeseeksmachine
Copy link

Backport PR #3282: Add nbclassic dependency to resolve popout error

@lumberbot-app lumberbot-app bot added this to the 4.0.1 milestone Nov 14, 2024
@lumberbot-app lumberbot-app bot added the bug Something isn't working label Nov 14, 2024
@lumberbot-app lumberbot-app bot added the trivial Only needs one approval instead of two label Nov 14, 2024
@lumberbot-app lumberbot-app bot added dependencies Pull requests that update a dependency file 💤backport-v4.0.x on-merge: backport to v4.0.x labels Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (2e43f13) to head (fbd97a5).
Report is 1 commits behind head on v4.0.x.

Additional details and impacted files
@@           Coverage Diff           @@
##           v4.0.x    #3291   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files         125      125           
  Lines       18792    18792           
=======================================
  Hits        16658    16658           
  Misses       2134     2134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosteen rosteen merged commit 49a0d13 into spacetelescope:v4.0.x Nov 14, 2024
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file trivial Only needs one approval instead of two 💤backport-v4.0.x on-merge: backport to v4.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants