Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #3282 on branch v4.0.x (Add nbclassic dependency to resolve popout error) #3291

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ Bug Fixes
- Fixed Aperture Photometry radial profile fit crashing when NaN is present in
aperture data for Cubeviz and Imviz. [#3246]

- Prevent PluginMarks from converting y-range so they maintain their position
- Prevent PluginMarks from converting y-range so they maintain their position
in the spectrum-viewer when spectral y units are converted. [#3242]

- Added ``nbclassic`` dependency to fix ``solara``-based popouts. [#3282]

Cubeviz
^^^^^^^

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ dependencies = [
"ipypopout>=2.0.0",
"astroquery",
"requests",
"nbclassic",
]
dynamic = [
"version",
Expand Down
Loading