RCAL-878: TVAC Node Saving #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…oman_datamodels into RCAL-879_TVACFilename
for more information, see https://pre-commit.ci
…e/roman_datamodels into RCAL-878_TVACDNodeSaving
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
+ Coverage 97.56% 97.66% +0.10%
==========================================
Files 30 36 +6
Lines 2788 3335 +547
==========================================
+ Hits 2720 3257 +537
- Misses 68 78 +10 ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
attempt to simplify tvac handling
braingram
approved these changes
Aug 1, 2024
braingram
reviewed
Aug 1, 2024
braingram
reviewed
Aug 1, 2024
Co-authored-by: Brett Graham <brettgraham@gmail.com>
Co-authored-by: Brett Graham <brettgraham@gmail.com>
Co-authored-by: Brett Graham <brettgraham@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-878
Closes #361
This PR addresses extra TVAC specific data being saved in RomanCAL.
Checklist
CHANGES.rstunder the corresponding subsection