Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rcal-622 Add the ability to copy resultantdq from SDF to a rampmodel #1085

Merged
merged 8 commits into from
Jan 31, 2024

Conversation

ddavis-stsci
Copy link
Collaborator

@ddavis-stsci ddavis-stsci commented Jan 30, 2024

Resolves RCAL-622

Closes #814

This PR adds the ability to copy resultantdq from a SDF science raw model to the new rampmodel created by dq_init.

Checklist

ddavis-stsci and others added 2 commits January 29, 2024 11:28
Co-authored-by: Eddie Schlafly <eschlafly@gmail.com>
@ddavis-stsci ddavis-stsci added this to the 24Q2_B13 milestone Jan 30, 2024
@ddavis-stsci ddavis-stsci self-assigned this Jan 30, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation testing labels Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.75%. Comparing base (d81a992) to head (e984921).
Report is 439 commits behind head on main.

Files Patch % Lines
romancal/dq_init/dq_init_step.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage   76.74%   76.75%           
=======================================
  Files         105      105           
  Lines        7013     7016    +3     
=======================================
+ Hits         5382     5385    +3     
  Misses       1631     1631           
Flag Coverage Δ *Carryforward flag
nightly 62.99% <ø> (-0.03%) ⬇️ Carriedforward from d81a992

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added dependencies Pull requests that update a dependency file regression_testing automation labels Jan 31, 2024
@ddavis-stsci ddavis-stsci marked this pull request as ready for review January 31, 2024 13:57
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner January 31, 2024 13:57
@ddavis-stsci ddavis-stsci requested a review from schlafly January 31, 2024 13:58
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It looks to me separate from this PR, but my recollection is that our guidance to SDF is that they should not include a resultantdq array when there are no flagged pixels, which we expect to be the case for >99% of real images. Is that also what you're thinking?

@ddavis-stsci
Copy link
Collaborator Author

That is correct, the resultantdq should be present only if there are data drops in the telemetry.

@ddavis-stsci ddavis-stsci merged commit 3853fc4 into spacetelescope:main Jan 31, 2024
30 checks passed
@ddavis-stsci ddavis-stsci deleted the rcal-622_dsd branch January 31, 2024 16:54
@braingram braingram mentioned this pull request Sep 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation dq_init testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dqinit to look for an incoming dq array in the level 1 files
3 participants