-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rcal-622 Add the ability to copy resultantdq from SDF to a rampmodel #1085
Conversation
2661712
to
8d5af2a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage 76.74% 76.75%
=======================================
Files 105 105
Lines 7013 7016 +3
=======================================
+ Hits 5382 5385 +3
Misses 1631 1631
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9ff6312
to
b661941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. It looks to me separate from this PR, but my recollection is that our guidance to SDF is that they should not include a resultantdq array when there are no flagged pixels, which we expect to be the case for >99% of real images. Is that also what you're thinking?
That is correct, the resultantdq should be present only if there are data drops in the telemetry. |
Resolves RCAL-622
Closes #814
This PR adds the ability to copy resultantdq from a SDF science raw model to the new rampmodel created by dq_init.
Checklist
CHANGES.rst
under the corresponding subsectionhttps://plwishmaster.stsci.edu:8081/job/RT/job/Roman-Developers-Pull-Requests/570/
The failures are all from requiring wcs and renaming the roman_datamodel which is being addressed in the coming rad and datamodels release.