unpin pytest #1409
Merged
unpin pytest #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1409 +/- ##
=======================================
Coverage 78.52% 78.52%
=======================================
Files 117 117
Lines 7833 7833
=======================================
Hits 6151 6151
Misses 1682 1682
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This fails out of the box so I think we need more work |
|
It looks like your doctestplus is out of date. The CI passes (and my tests do locally) since they're using a newer doctestplus. The test deps for romancal don't all have lower pins and doctestplus is not a direct dependency (it's a dependency of pytest-astropy). I added a lower pin for pytest-astropy. Would you try it again? |
|
That fails even more spectacularly, |
|
I have no idea what is wrong with your environment but that's not what I see locally or in the CI. Since it's passing for me and for the CI would you try with a fresh environment as yours appears to be broken? |
braingram
force-pushed
the
unpin_pytest
branch
from
cb81220 to
1040e46
Compare
mairanteodoro
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
I was able to apply the changes in this PR and then install romancal successfully on my machine. I did not run into the issues reported by @ddavis-stsci.
Looks good to me!
Thanks, @braingram!
|
Thanks! @ddavis-stsci let me know if you continue to run into issues and I'd be happy to help sort them out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the upper pin for pytest and updates the lower pin.
It's unclear why #1085 added the upper pin.
This caused issues during testing with stasis as some packages use pytest > 8.0.
Regression tests all passed: https://github.com/spacetelescope/RegressionTests/actions/runs/10814310251
Checklist
for a public change, added a towncrier news fragment in
changes/echo "changed something" > changes/<PR#>.<changetype>.rstchanges/<PR#>.general.rst: infrastructure or miscellaneous changechanges/<PR#>.docs.rstchanges/<PR#>.stpipe.rstchanges/<PR#>.associations.rstchanges/<PR#>.scripts.rstchanges/<PR#>.mosaic_pipeline.rstchanges/<PR#>.patch_match.rststeps
changes/<PR#>.dq_init.rstchanges/<PR#>.saturation.rstchanges/<PR#>.refpix.rstchanges/<PR#>.linearity.rstchanges/<PR#>.dark_current.rstchanges/<PR#>.jump_detection.rstchanges/<PR#>.ramp_fitting.rstchanges/<PR#>.assign_wcs.rstchanges/<PR#>.flatfield.rstchanges/<PR#>.photom.rstchanges/<PR#>.flux.rstchanges/<PR#>.source_detection.rstchanges/<PR#>.tweakreg.rstchanges/<PR#>.skymatch.rstchanges/<PR#>.outlier_detection.rstchanges/<PR#>.resample.rstchanges/<PR#>.source_catalog.rstupdated relevant tests
updated relevant documentation
updated relevant milestone(s)
added relevant label(s)
ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR