Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcal-890 Update Docs for B15 #1396

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

ddavis-stsci
Copy link
Collaborator

@ddavis-stsci ddavis-stsci commented Sep 4, 2024

Resolves RCAL-890

Closes #1365

This PR updates the documentation for the roman pipelines to include the catalogs and segmentation maps generated in the roman_elp and roman_mos pipelines.

Checklist

  • [N/A] added entry in CHANGES.rst under the corresponding subsection
  • [N/A] updated relevant tests
  • updated relevant documentation
  • updated relevant milestone(s)
  • added relevant label(s)
  • [N/A] ran regression tests, post a link to the Jenkins job below. How to run regression tests on a PR

@ddavis-stsci ddavis-stsci added documentation Improvements or additions to documentation no-changelog-entry-needed labels Sep 4, 2024
@ddavis-stsci ddavis-stsci added this to the 24Q4_B15 milestone Sep 4, 2024
@ddavis-stsci ddavis-stsci self-assigned this Sep 4, 2024
@ddavis-stsci ddavis-stsci requested a review from a team as a code owner September 4, 2024 15:00
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.49%. Comparing base (9cde4cb) to head (2e8f8c2).
Report is 256 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1396   +/-   ##
=======================================
  Coverage   78.49%   78.49%           
=======================================
  Files         117      117           
  Lines        7867     7867           
=======================================
  Hits         6175     6175           
  Misses       1692     1692           
Flag Coverage Δ *Carryforward flag
nightly 62.24% <ø> (ø) Carriedforward from 9cde4cb

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks. I was worried on the call that we might not have much source catalog descriptions, but I was wrong; the description is quite good.
https://roman-pipeline.readthedocs.io/en/latest/roman/source_catalog/main.html

@ddavis-stsci ddavis-stsci merged commit 9e2b4d3 into spacetelescope:main Sep 6, 2024
30 checks passed
@ddavis-stsci ddavis-stsci deleted the rcal-890_dsd branch September 6, 2024 14:51
mairanteodoro pushed a commit to mairanteodoro/romancal that referenced this pull request Sep 10, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation no-changelog-entry-needed pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

romancal mosaic pipeline documentation issues
2 participants