remove okify_regtests script (moved to ci_watson)

[zacharyburnett]

Resolves SCSB-183

moves okify_regtests to a generalized version in ci_watson (see spacetelescope/ci_watson#69)

Tasks

• request a review from someone specific, to avoid making the maintainers review every PR
• add a build milestone, i.e. 24Q4_B15 (use the latest build if not sure)
• Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • start a regression test and include a link to the running job (click here for instructions)
    • Do truth files need to be updated ("okified")?
      • after the reviewer has approved these changes, run okify_regtests to update the truth files
• if a JIRA ticket exists, make sure it is resolved properly

news fragment change types...

• changes/<PR#>.general.rst: infrastructure or miscellaneous change
• changes/<PR#>.docs.rst
• changes/<PR#>.stpipe.rst
• changes/<PR#>.associations.rst
• changes/<PR#>.scripts.rst
• changes/<PR#>.mosaic_pipeline.rst
• changes/<PR#>.patch_match.rst

steps

• changes/<PR#>.dq_init.rst
• changes/<PR#>.saturation.rst
• changes/<PR#>.refpix.rst
• changes/<PR#>.linearity.rst
• changes/<PR#>.dark_current.rst
• changes/<PR#>.jump_detection.rst
• changes/<PR#>.ramp_fitting.rst
• changes/<PR#>.assign_wcs.rst
• changes/<PR#>.flatfield.rst
• changes/<PR#>.photom.rst
• changes/<PR#>.flux.rst
• changes/<PR#>.source_detection.rst
• changes/<PR#>.tweakreg.rst
• changes/<PR#>.skymatch.rst
• changes/<PR#>.outlier_detection.rst
• changes/<PR#>.resample.rst
• changes/<PR#>.source_catalog.rst

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.10%. Comparing base (b37aee9) to head (31b66e2).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1513      +/-   ##
==========================================
+ Coverage   77.55%   78.10%   +0.55%     
==========================================
  Files         118      117       -1     
  Lines        7721     7642      -79     
==========================================
- Hits         5988     5969      -19     
+ Misses       1733     1673      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[schlafly]

This looks reasonable to me. Presumably some documentation needs to be updated with the new syntax (just adding "roman" to the command). Would you want to introduce this change to the group at the tag up today?

[zacharyburnett]

This looks reasonable to me. Presumably some documentation needs to be updated with the new syntax (just adding "roman" to the command). Would you want to introduce this change to the group at the tag up today?

sure! The one at 3p, right?

[schlafly]

Yes, thanks!

[braingram]

Tested ci_watson version with #1525
Files were updated successfully.

[zacharyburnett]

Great! I'll go ahead and merge these PRs then!