-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
write okify_regtests
script, generalizing jwst
and romancal
versions
#69
write okify_regtests
script, generalizing jwst
and romancal
versions
#69
Conversation
b52ed23
to
b4a9d24
Compare
okify_regtests
scriptjwst
and romancal
versions
jwst
and romancal
versionsokify_regtests
script, generalizing jwst
and romancal
versions
b4a9d24
to
66b6ef0
Compare
66b6ef0
to
96d9d54
Compare
@spacetelescope/jwst-pipeline-maintainers @spacetelescope/jwst-pipeline-developers @spacetelescope/romancal-maintainers thoughts on this consolidation? |
added |
Could you add basic documentation for this in the |
@melanieclarke as you use |
@zacharyburnett - will do, next time I have something to okify. Thanks for working on this! |
I tested okify_regtests from this branch for jwst for diffs from spacetelescope/jwst#8847, with: It looks like all went well - it found the two diffs I expected and copied them to the right place in artifactory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, for jwst.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with romancal (see spacetelescope/romancal#1513) with no issues. Feel free to merge (I don't have permissions to merge).
resolves SCSB-183
follow-up to spacetelescope/jwst#8762
adds the
okify_regtests
script to theci_watson
package, generalized between the existingjwst
andromancal
versions:This change would be coupled with removals of
okify_regtests
from bothjwst
andromancal
:okify_regtests
script (moved toci_watson
) jwst#8957okify_regtests
script (moved toci_watson
) romancal#1513Arguments
Usage Examples