Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sanity checks to data formatting tools #1523

Closed
ambrosejcarr opened this issue Aug 30, 2019 · 0 comments · Fixed by #1525
Closed

Add sanity checks to data formatting tools #1523

ambrosejcarr opened this issue Aug 30, 2019 · 0 comments · Fixed by #1525
Labels
feature New work

Comments

@ambrosejcarr
Copy link
Member

Objective

As a user of spacetx format, I want starfish to catch common errors so that it's easier to debug simple problems in data formatting

Acceptance Criteria

  • a warning is emitted if the shape of x & y aren't >= the shape of r, c, and z

Notes

See: #1502 for rationale
@ambrosejcarr ambrosejcarr added the feature New work label Aug 30, 2019
@ttung ttung mentioned this issue Aug 30, 2019
Merged
ttung pushed a commit that referenced this issue Sep 5, 2019
Throw a warning when the data size is unusual. (#1525)
afdff1c 
If num_round/num_ch/num_zplane > X or Y size, then throw a warning.

Fixes #1523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw a warning when the data size is unusual. spacetx/starfish
1 participant
@ambrosejcarr