Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a warning when the data size is unusual. #1525

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Aug 30, 2019

If num_round/num_ch/num_zplane > X or Y size, then throw a warning.

Fixes #1523

@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #1525 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1525      +/-   ##
==========================================
+ Coverage    87.1%   87.11%   +0.01%     
==========================================
  Files         139      139              
  Lines        4988     4992       +4     
==========================================
+ Hits         4345     4349       +4     
  Misses        643      643
Impacted Files Coverage Δ
starfish/core/experiment/builder/__init__.py 96.62% <100%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 323cbe7...ced6505. Read the comment docs.

@ttung ttung force-pushed the tonytung-weird-data-size branch 2 times, most recently from d53068e to 8479ead Compare September 5, 2019 07:30
If num_round/num_ch/num_zplane > X or Y size, then throw a warning.

Fixes #1523
@ttung ttung merged commit afdff1c into master Sep 5, 2019
@ttung ttung deleted the tonytung-weird-data-size branch September 5, 2019 19:04
@ttung ttung restored the tonytung-weird-data-size branch September 5, 2019 19:13
@ttung ttung deleted the tonytung-weird-data-size branch September 5, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sanity checks to data formatting tools
2 participants