Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate "dots" image vocabulary #220

Closed
ambrosejcarr opened this issue May 25, 2018 · 4 comments · Fixed by #1379
Closed

Investigate "dots" image vocabulary #220

ambrosejcarr opened this issue May 25, 2018 · 4 comments · Fixed by #1379
Labels
research issues/questions opened for research purposes

Comments

@ambrosejcarr
Copy link
Member

We generate a bunch of "dots" images that represent bright spots in the image. These are typically max projections over some subset of the data. Brian long suggested we might want to store some information on how such projections were created (e.g. max projection over z? z, h, and c?

Determine how to store this data in starfish and the starfish spec.

@ttung
Copy link
Collaborator

ttung commented May 25, 2018

maybe max-proj-{axes-list, sorted}

@ambrosejcarr
Copy link
Member Author

I like it, except I'd be verbose: maximum-projection-{axes-list, sorted}

@ambrosejcarr
Copy link
Member Author

Now that we use xarray, we can store arbitrary metadata on the DataArray object. I also opened #449 because I think max projection should generate a new ImageStack. It could be possible to store such information on the provenance of the new imagestacks in the attrs field. That would be really neat, as users would be able to see how their data was processed.

@ambrosejcarr ambrosejcarr removed their assignment Sep 21, 2018
@neuromusic neuromusic added this to the 0.1.0 milestone Dec 19, 2018
@ambrosejcarr
Copy link
Member Author

@shanaxel42 how hard would it be for max_proj to be recorded in the log? I think that's all that is left to close out this issue.

@neuromusic neuromusic removed this from the 0.2.0 milestone May 3, 2019
@shanaxel42 shanaxel42 added research issues/questions opened for research purposes and removed data formats labels May 7, 2019
ttung pushed a commit that referenced this issue Oct 10, 2019
Remove ImageStack.max_proj. Steer users towards using ImageStack.reduce.

Test plan: travis

Addresses comment in https://github.com/spacetx/starfish/pull/1342/files#r288261378
Fixes #220
ttung pushed a commit that referenced this issue Oct 10, 2019
Remove ImageStack.max_proj. Steer users towards using ImageStack.reduce.

Test plan: travis

Addresses comment in https://github.com/spacetx/starfish/pull/1342/files#r288261378
Fixes #220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research issues/questions opened for research purposes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants