clean up max projection #1379
Merged
clean up max projection #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttung
force-pushed
the
tonytung-max-proj
branch
7 times, most recently
from
c700eac
to
55edf6c
Compare
shanaxel42
approved these changes
Jun 3, 2019
ttung
force-pushed
the
tonytung-max-proj
branch
2 times, most recently
from
fe50c6a
to
4ad94f1
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
5 times, most recently
from
40cfa64
to
1a13d5c
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
2 times, most recently
from
e5f7061
to
ea9ae4d
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
2 times, most recently
from
665b3ab
to
81c174e
Compare
shanaxel42
added
the
tech debt
ttung
force-pushed
the
tonytung-max-proj
branch
5 times, most recently
from
3b3f784
to
647ea90
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
from
0129887
to
b19f093
Compare
ttung
force-pushed
the
tonytung-use-map-reduce
branch
from
3380d78
to
88261ac
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
3 times, most recently
from
bf6e033
to
62d754d
Compare
ttung
force-pushed
the
tonytung-use-map-reduce
branch
from
28d15b0
to
8e93d48
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
3 times, most recently
from
d8890b7
to
6c5cc8f
Compare
ttung
force-pushed
the
tonytung-use-map-reduce
branch
from
5a0648e
to
ff2af22
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
from
6c5cc8f
to
9c52d73
Compare
ttung
force-pushed
the
tonytung-use-map-reduce
branch
from
ff2af22
to
a180d72
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
from
9c52d73
to
5973e53
Compare
ttung
force-pushed
the
tonytung-use-map-reduce
branch
from
a180d72
to
599453e
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
2 times, most recently
from
0c04949
to
eea4824
Compare
ttung
force-pushed
the
tonytung-use-map-reduce
branch
from
aa5a5d0
to
b0d40ab
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
2 times, most recently
from
41b9066
to
798ff1d
Compare
ttung
force-pushed
the
tonytung-use-map-reduce
branch
from
28c9b35
to
c346506
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
3 times, most recently
from
dc0837b
to
f0da3e0
Compare
ttung
force-pushed
the
tonytung-use-map-reduce
branch
from
7cd93ae
to
f612f8a
Compare
ttung
force-pushed
the
tonytung-max-proj
branch
from
f0da3e0
to
150d243
Compare
Remove ImageStack.max_proj. Steer users towards using ImageStack.reduce. Test plan: travis Addresses comment in https://github.com/spacetx/starfish/pull/1342/files#r288261378 Fixes #220
ttung
force-pushed
the
tonytung-max-proj
branch
from
150d243
to
b0e553b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove ImageStack.max_proj. Steer users towards using ImageStack.reduce.
Test plan: travis
Addresses comment in https://github.com/spacetx/starfish/pull/1342/files#r288261378
Fixes #220
Depends on #1548