Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code coverage detection #1115

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Fix code coverage detection #1115

merged 1 commit into from
Mar 28, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Mar 27, 2019

Exclude the test files from the calculations of what code is covered.

Also exclude the file that's autogenerated by versioneer.

This is based on #1111

@ttung ttung requested review from shanaxel42 and kne42 March 27, 2019 07:17
@ttung ttung force-pushed the tonytung-mv-tests branch from 126ff1f to f9c947c Compare March 27, 2019 07:18
@ttung ttung force-pushed the tonytung-codecov branch from 0f01c79 to b5e399f Compare March 27, 2019 07:18
@codecov-io
Copy link

codecov-io commented Mar 27, 2019

Codecov Report

Merging #1115 into tonytung-mv-tests will decrease coverage by 16.54%.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tonytung-mv-tests    #1115       +/-   ##
======================================================
- Coverage              88.87%   72.32%   -16.55%     
======================================================
  Files                    167      167               
  Lines                   6516     6516               
======================================================
- Hits                    5791     4713     -1078     
- Misses                   725     1803     +1078
Impacted Files Coverage Δ
starfish/imagestack/test/test_imagestack_index.py 13.79% <0%> (-86.21%) ⬇️
starfish/intensity_table/test/test_concatenate.py 15.38% <0%> (-84.62%) ⬇️
starfish/codebook/test/test_from_code_array.py 20.28% <0%> (-79.72%) ⬇️
starfish/config/test/test_config.py 21.89% <0%> (-78.11%) ⬇️
starfish/imagestack/test/test_imagestack.py 20.8% <0%> (-77.19%) ⬇️
starfish/image/_filter/test/test_white_tophat.py 23.33% <0%> (-76.67%) ⬇️
...tarfish/codebook/test/test_per_round_max_decode.py 25.58% <0%> (-74.42%) ⬇️
starfish/imagestack/test/test_apply.py 26.08% <0%> (-73.92%) ⬇️
...rfish/intensity_table/test/test_from_imagestack.py 28.57% <0%> (-71.43%) ⬇️
..._decoder/test/test_intensities_to_decoded_image.py 28.57% <0%> (-71.43%) ⬇️
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e3ec9...f24a411. Read the comment docs.

@ttung ttung force-pushed the tonytung-mv-tests branch from f9c947c to 94ade76 Compare March 27, 2019 17:57
@ttung ttung force-pushed the tonytung-codecov branch 2 times, most recently from 04e9805 to f24a411 Compare March 27, 2019 17:57
@ttung ttung changed the base branch from tonytung-mv-tests to master March 28, 2019 04:47
Exclude the test files from the calculations of what code is covered.

Also exclude the file that's autogenerated by versioneer.
@ttung ttung force-pushed the tonytung-codecov branch from f24a411 to 68143b8 Compare March 28, 2019 04:48
@ttung ttung merged commit 6740d1d into master Mar 28, 2019
@ttung ttung deleted the tonytung-codecov branch March 28, 2019 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants