Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all the tests into the module they are testing. #1111

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Mar 26, 2019

For example, starfish/test/experiment/builder/* is getting moved to starfish/experiment/builder/test.

This simplifies navigation in the IDE, and also ensures we put the tests in the right place (c.f., all the filter tests in starfish/test/pipeline).

Test plan: make -j fast lint mypy

@ttung ttung force-pushed the tonytung-mv-tests branch 3 times, most recently from d629d1f to 126ff1f Compare March 26, 2019 22:45
@codecov-io
Copy link

codecov-io commented Mar 26, 2019

Codecov Report

Merging #1111 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
- Coverage   88.91%   88.87%   -0.05%     
==========================================
  Files         168      167       -1     
  Lines        6542     6516      -26     
==========================================
- Hits         5817     5791      -26     
  Misses        725      725
Impacted Files Coverage Δ
...arfish/spots/_detector/test/test_spot_detection.py 100% <ø> (ø)
...fish/spots/_pixel_decoder/test/test_targets_map.py 100% <ø> (ø)
...ish/imagestack/test/test_imagestack_coordinates.py 96.42% <ø> (ø)
...rfish/multiprocessing/test/test_multiprocessing.py 92.3% <ø> (ø)
starfish/imagestack/test/imagestack_test_utils.py 100% <ø> (ø)
...l_decoder/test/test_calculate_mean_pixel_traces.py 100% <ø> (ø)
...ntensity_table/test/test_intensity_table_coords.py 97.14% <ø> (ø)
starfish/intensity_table/test/test_concatenate.py 100% <ø> (ø)
starfish/codebook/test/test_metric_decode.py 100% <ø> (ø)
starfish/codebook/test/test_from_code_array.py 100% <ø> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ec73d6...b7e3ec9. Read the comment docs.

@ttung ttung force-pushed the tonytung-mv-tests branch 2 times, most recently from f9c947c to 94ade76 Compare March 27, 2019 17:57
For example, starfish/test/experiment/builder/* is getting moved to starfish/experiment/builder/test.

This simplifies navigation in the IDE, and also ensures we put the tests in the right place (c.f., all the filter tests in starfish/test/pipeline).

Test plan: `make -j fast lint mypy`
@ttung ttung force-pushed the tonytung-mv-tests branch from 94ade76 to b7e3ec9 Compare March 27, 2019 17:57
@ttung ttung merged commit b2fdb94 into master Mar 28, 2019
@ttung ttung deleted the tonytung-mv-tests branch March 28, 2019 04:49
@kne42
Copy link
Collaborator

kne42 commented Mar 29, 2019

just saw this but 😍 😍 😍

@ttung ttung mentioned this pull request Apr 3, 2019
ttung pushed a commit that referenced this pull request Apr 3, 2019
I accidentally removed these tests as part of #1111.  Putting them back.
ttung added a commit that referenced this pull request Apr 3, 2019
I accidentally removed these tests as part of #1111.  Putting them back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants