Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] Modularize segmentation mask #1578

Merged
merged 1 commit into from
Sep 27, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Sep 25, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #1578 into master will increase coverage by <.01%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1578      +/-   ##
==========================================
+ Coverage   87.58%   87.59%   +<.01%     
==========================================
  Files         144      146       +2     
  Lines        5049     5053       +4     
==========================================
+ Hits         4422     4426       +4     
  Misses        627      627
Impacted Files Coverage Δ
starfish/core/segmentation_mask/__init__.py 100% <100%> (ø)
...arfish/core/segmentation_mask/segmentation_mask.py 95.65% <100%> (ø)
starfish/core/segmentation_mask/util.py 92.3% <92.3%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad9010f...a48ff89. Read the comment docs.

@ttung ttung force-pushed the tonytung-modularize-segmentation-mask branch from fe68b51 to a48ff89 Compare September 26, 2019 23:19
@ttung ttung mentioned this pull request Sep 26, 2019
@ttung ttung merged commit f73a953 into master Sep 27, 2019
@ttung ttung deleted the tonytung-modularize-segmentation-mask branch September 27, 2019 17:53
ttung pushed a commit that referenced this pull request Oct 10, 2019
This method allows us to produce a labeled image with minimal looping in python.  It takes a mask array with labeled axes, a fill value, and writes the fill value into the result array where mask is True.

Depends on #1578
Test plan: see tests that are written
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants