Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SegmentationMaskCollection to a dict-like object #1579

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Sep 25, 2019

Maps from cell id to mask.

Depends on #1578
Part of #1497

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #1579 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1579      +/-   ##
==========================================
- Coverage   88.04%   88.02%   -0.02%     
==========================================
  Files         151      151              
  Lines        5171     5171              
==========================================
- Hits         4553     4552       -1     
- Misses        618      619       +1
Impacted Files Coverage Δ
starfish/core/spots/AssignTargets/label.py 96% <100%> (ø) ⬆️
...arfish/core/segmentation_mask/segmentation_mask.py 94.56% <100%> (-1.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58eb7ac...c01cf80. Read the comment docs.

@ttung ttung force-pushed the tonytung-modularize-segmentation-mask branch from fe68b51 to a48ff89 Compare September 26, 2019 23:19
@ttung ttung changed the base branch from tonytung-modularize-segmentation-mask to master September 27, 2019 17:53
@ttung ttung force-pushed the tonytung-mask-to-dict branch 2 times, most recently from 22f2204 to dc40240 Compare October 2, 2019 06:16
@ttung ttung force-pushed the tonytung-mask-to-dict branch 2 times, most recently from cf81ec8 to d89f4c0 Compare October 9, 2019 21:14
@ttung ttung force-pushed the tonytung-mask-to-dict branch 2 times, most recently from 4e1b15e to ef7e153 Compare October 10, 2019 06:19
@ttung ttung merged commit a9a3d13 into master Oct 10, 2019
@ttung ttung deleted the tonytung-mask-to-dict branch October 10, 2019 17:38
@ttung ttung restored the tonytung-mask-to-dict branch October 10, 2019 17:44
ttung pushed a commit that referenced this pull request Oct 10, 2019
Replace the existing code with masked fill.

Depends on #1579, #1581
ttung pushed a commit that referenced this pull request Oct 10, 2019
Replace the existing code with masked fill.

Depends on #1579, #1581
@ttung ttung deleted the tonytung-mask-to-dict branch October 10, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants