Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] updates for napari 0.2.0 release #1591

Closed
wants to merge 1 commit into from
Closed

Conversation

sofroniewn
Copy link
Collaborator

This PR will update starfish.display for the 0.2.0 release of napari which is planned imminently but has not happened yet. I still need to test it out more thoroughly, but wanted to make the changes that I know we'll need to make

@codecov-io
Copy link

codecov-io commented Sep 30, 2019

Codecov Report

Merging #1591 into master will increase coverage by 0.06%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
+ Coverage   87.59%   87.66%   +0.06%     
==========================================
  Files         146      146              
  Lines        5053     5049       -4     
==========================================
  Hits         4426     4426              
+ Misses        627      623       -4
Impacted Files Coverage Δ
starfish/core/_display.py 23.59% <50%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73a953...2386169. Read the comment docs.

@sofroniewn
Copy link
Collaborator Author

I'm confused why the tests are passing - after #1570 they should break as I've added code that should break the version of napari currently on pypi 0.1.5

@ttung
Copy link
Collaborator

ttung commented Oct 1, 2019

Napari tests are only run on master, or branches with the suffix '-alltest'

@sofroniewn
Copy link
Collaborator Author

Closing in favour of #1599 which has the correct branch name and the only changes that are actually needed

@sofroniewn sofroniewn closed this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants