starfish.display: unpin napari version, add tests, view masks separately #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kne42
requested review from
ttung,
dganguli,
ambrosejcarr,
sofroniewn and
shanaxel42
1. Run them as part of the napari install test that's run on master branches. 2. Move the napari and pyqt imports inside test_display() so they don't trip up tests when napari isn't installed. 3. Upgrade pytest version. Test plan: named this branch -alltest, so it should hit all the test cases.
Separate napari tests into its own category
ttung
approved these changes
Sep 24, 2019
ttung
pushed a commit
that referenced
this pull request
Sep 24, 2019
…ely (#1570) * display: unpin napari version, add tests, view masks separately * Separate napari tests into its own category 1. Run them as part of the napari install test that's run on master branches. 2. Move the napari and pyqt imports inside test_display() so they don't trip up tests when napari isn't installed. 3. Upgrade pytest version. Test plan: named this branch -alltest, so it should hit all the test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
starfish.display:0.1.5)please note that we had to use a hack to test the module as
pytest-qtwas not working properly for unknown reasons