Clean up the existing watershed algorithm #1652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1652 +/- ##
==========================================
+ Coverage 89.67% 89.69% +0.01%
==========================================
Files 220 220
Lines 8236 8236
==========================================
+ Hits 7386 7387 +1
+ Misses 850 849 -1
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-watershed-cleanup
branch
from
4eb43f4 to
4661696
Compare
shanaxel42
approved these changes
Nov 18, 2019
1. Refactor some anonymous numpy functionality into a pipeline-component-like model. 2. Remove unnecessary work in ISS.py (stuff that's been inlined into Segment.Watershed ages ago). Test plan: Ran iss.py and got 69 segmented cells, same as before this change
ttung
force-pushed
the
tonytung-watershed-cleanup
branch
from
4661696 to
e0d390d
Compare
ttung
pushed a commit
that referenced
this pull request
Dec 3, 2019
#1652 replaced a block of code that scales the intensity of the image by the max, with a reduce operation that does Clip.SCALE_BY_IMAGE. As I discovered later, Clip.SCALE_BY_IMAGE does not do what the documentation says it does, and in fact, it only scales by the max intensity if the max intensity is > 1.0. That means it's not a refactor and actually affected the output. Levels.SCALE_BY_IMAGE, however, does what we want here and can do what we originally had here. Depends on #1669 Test plan: pretty much none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: Ran iss.py and got 69 segmented cells, same as before this change