Use the new levels module. #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1669 +/- ##
========================================
- Coverage 90.2% 90.1% -0.1%
========================================
Files 231 231
Lines 8808 8835 +27
========================================
+ Hits 7945 7961 +16
- Misses 863 874 +11
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-use-levels-alltest
branch
2 times, most recently
from
d86fdd3 to
da6a80c
Compare
ttung
force-pushed
the
tonytung-use-levels-base
branch
from
e4c18d3 to
d5a752f
Compare
ttung
force-pushed
the
tonytung-use-levels-alltest
branch
from
da6a80c to
89bc8ed
Compare
ttung
changed the base branch from
tonytung-use-levels-base
to
tonytung-levels
ttung
force-pushed
the
tonytung-use-levels-alltest
branch
from
89bc8ed to
17a4d5f
Compare
shanaxel42
approved these changes
Dec 3, 2019
Adjusts all the filters to use levels instead of clip/preserve_float_range. `clip_method` is still supported though deprecated. If both are provided, an exception is thrown. If `clip_method` by itself is provided, then a deprecation warning is printed and the `clip_method` is translated to the appropriate `levels_method`. Depends on #1666, #1668 Test plan: this is an -alltest branch since it affects so much code. if goes green, we should presumably be good. :)
ttung
force-pushed
the
tonytung-use-levels-alltest
branch
from
17a4d5f to
6e2a100
Compare
ttung
pushed a commit
that referenced
this pull request
Dec 3, 2019
#1652 replaced a block of code that scales the intensity of the image by the max, with a reduce operation that does Clip.SCALE_BY_IMAGE. As I discovered later, Clip.SCALE_BY_IMAGE does not do what the documentation says it does, and in fact, it only scales by the max intensity if the max intensity is > 1.0. That means it's not a refactor and actually affected the output. Levels.SCALE_BY_IMAGE, however, does what we want here and can do what we originally had here. Depends on #1669 Test plan: pretty much none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts all the filters to use levels instead of clip/preserve_float_range.
clip_methodis still supported though deprecated. If both are provided, an exception is thrown. Ifclip_methodby itself is provided, then a deprecation warning is printed and theclip_methodis translated to the appropriatelevels_method.Depends on #1666, #1668
Test plan: this is an -alltest branch since it affects so much code. if goes green, we should presumably be good. :)