Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] fix deprecation warnings for indexing using a sequence #1690

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Dec 10, 2019

xarray prefers to be indexed with a tuple of selectors rather than a sequence. Update the API to generate tuples and use them instead.

Test plan: Saw fewer deprecation warnings in the test console.

xarray prefers to be indexed with a tuple of selectors rather than a sequence.  Update the API to generate tuples and use them instead.

Test plan: Saw fewer deprecation warnings in the test console.
@codecov-io
Copy link

Codecov Report

Merging #1690 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1690      +/-   ##
==========================================
+ Coverage   89.85%   89.85%   +<.01%     
==========================================
  Files         239      239              
  Lines        8966     8967       +1     
==========================================
+ Hits         8056     8057       +1     
  Misses        910      910
Impacted Files Coverage Δ
starfish/core/morphology/binary_mask/expand.py 89.47% <100%> (+0.58%) ⬆️
...tarfish/core/morphology/binary_mask/binary_mask.py 95.08% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48171c...22622e4. Read the comment docs.

@ttung ttung merged commit f780517 into master Dec 11, 2019
@ttung ttung deleted the tonytung-fix-deprecation branch December 11, 2019 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants