Pipeline component and implementation for merging BinaryMaskCollections #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1692 +/- ##
==========================================
+ Coverage 89.78% 89.96% +0.18%
==========================================
Files 241 245 +4
Lines 9071 9148 +77
==========================================
+ Hits 8144 8230 +86
+ Misses 927 918 -9
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-merge-base
branch
from
79fb79b
to
9124802
Compare
ttung
force-pushed
the
tonytung-merge
branch
from
a130df8
to
16ccb21
Compare
ttung
changed the base branch from
tonytung-merge-base
to
tonytung-fix-3d-factory
ttung
force-pushed
the
tonytung-merge
branch
from
16ccb21
to
3e51889
Compare
ttung
force-pushed
the
tonytung-merge
branch
from
3e51889
to
20ad9b7
Compare
ttung
changed the base branch from
tonytung-fix-3d-factory
to
tonytung-merge-base
ttung
force-pushed
the
tonytung-merge-base
branch
from
4cc4d84
to
59ecc92
Compare
ttung
force-pushed
the
tonytung-merge
branch
from
20ad9b7
to
0191533
Compare
shanaxel42
approved these changes
Dec 13, 2019
| from .simple import SimpleMerge | ||
|
|
||
| # autodoc's automodule directive only captures the modules explicitly listed in __all__. | ||
| all_filters = { |
There was a problem hiding this comment.
Suggested change
| all_filters = { | |
| all_methods = { |
? are they all filters?
There was a problem hiding this comment.
You are correct. Will fix.
ttung
force-pushed
the
tonytung-merge
branch
from
0191533
to
731116c
Compare
ttung
force-pushed
the
tonytung-merge-base
branch
from
0effa7b
to
c6ccdfc
Compare
ttung
force-pushed
the
tonytung-merge
branch
2 times, most recently
from
2c6fa67
to
e120bda
Compare
ttung
force-pushed
the
tonytung-merge
branch
from
e120bda
to
6173066
Compare
ttung
force-pushed
the
tonytung-merge
branch
2 times, most recently
from
3aa90df
to
f8ebad0
Compare
This does not handle the case where the pixel/physical ticks do not line up. This is for cases where we derive the data from the exact same set of images, and inherit their pixel/physical ticks from the same source. Test plan: Added one positive test case, and tested the cases where the merge should fail.
ttung
force-pushed
the
tonytung-merge
branch
from
f8ebad0
to
65ac815
Compare
mattcai
pushed a commit
that referenced
this pull request
Dec 19, 2019
ttung
pushed a commit
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not handle the case where the pixel/physical ticks do not line up. This is for cases where we derive the data from the exact same set of images, and inherit their pixel/physical ticks from the same source.
Depends on #1690, #1691, #1696
Test plan: Added one positive test case, and tested the cases where the merge should fail.