Clean up watershed (again) #1693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttung
force-pushed
the
tonytung-cleanup-watershed
branch
from
8cbc439
to
27af3e6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1693 +/- ##
==========================================
- Coverage 89.78% 89.78% -0.01%
==========================================
Files 241 241
Lines 9076 9071 -5
==========================================
- Hits 8149 8144 -5
Misses 927 927
Continue to review full report at Codecov.
|
ttung
force-pushed
the
tonytung-cleanup-watershed
branch
from
27af3e6
to
5580d4a
Compare
ttung
force-pushed
the
tonytung-cleanup-watershed
branch
from
5580d4a
to
f650405
Compare
ttung
changed the base branch from
tonytung-simplify-functionsource
to
master
shanaxel42
approved these changes
Dec 13, 2019
ttung
force-pushed
the
tonytung-cleanup-watershed
branch
from
f650405
to
765fc3c
Compare
ttung
force-pushed
the
tonytung-cleanup-watershed
branch
from
765fc3c
to
3970112
Compare
ttung
force-pushed
the
tonytung-cleanup-watershed
branch
from
3970112
to
4192589
Compare
- Get rid of the remaining naked numpy arrays and replace them with ImageStacks. - Use ImageStack.reduce rather than instantiating a Reduce Filter and applying it. - Get rid of self.nuclei_thresholded as it is not used. Test plan: ran iss notebook and found 69 cells.
ttung
force-pushed
the
tonytung-cleanup-watershed
branch
from
4192589
to
f1d08f6
Compare
mattcai
pushed a commit
that referenced
this pull request
Dec 19, 2019
ttung
pushed a commit
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1686
Test plan: ran iss notebook and found 69 cells.