Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap skimage's watershed #1700

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Wrap skimage's watershed #1700

merged 1 commit into from
Dec 17, 2019

Conversation

ttung
Copy link
Collaborator

@ttung ttung commented Dec 13, 2019 •
edited
Loading

This PR adds a Binarizer that effectively wraps skimage's watershed implementation.

Test plan: used in subsequent PR.

@codecov-io
Copy link

codecov-io commented Dec 13, 2019 •
edited
Loading

Codecov Report

Merging #1700 into master will decrease coverage by 0.14%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1700      +/-   ##
==========================================
- Coverage   90.05%   89.91%   -0.15%     
==========================================
  Files         245      246       +1     
  Lines        9140     9168      +28     
==========================================
+ Hits         8231     8243      +12     
- Misses        909      925      +16
Impacted Files Coverage Δ
starfish/core/morphology/Binarize/__init__.py 100% <100%> (ø) ⬆️
starfish/core/morphology/Binarize/watershed.py 40.74% <40.74%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cadab6b...34261a8. Read the comment docs.

@ttung ttung mentioned this pull request Dec 14, 2019
Merged
Wrap skimage's watershed
34261a8 
This PR adds a Binarizer that effectively wraps skimage's watershed implementation.

Test plan: used in subsequent PR.
ttung pushed a commit that referenced this pull request Dec 16, 2019
Use the new watershed component to finish componentizing the existing…
d46d7a9 
… watershed

Use the component from #1700 to replace the remaining procedural code in the existing watershed component.

Depends on #1700, #1699, #1694
Test plan: visually the ISS notebook looks the same.
@ttung ttung merged commit 44b518b into master Dec 17, 2019
@ttung ttung deleted the tonytung-watershed branch December 17, 2019 22:03
ttung pushed a commit that referenced this pull request Jan 15, 2020
Use the new watershed component to finish componentizing the existing…
17785db 
… watershed (#1701)

Use the component from #1700 to replace the remaining procedural code in the existing watershed component.

Depends on #1700, #1699, #1694
Test plan: visually the ISS notebook looks the same.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanaxel42 shanaxel42 shanaxel42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttung @codecov-io @shanaxel42