Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react-scripts from 3.4.1 to 4.0.3 + fix associated tech debt #1102

Merged
merged 38 commits into from
May 6, 2021
Merged

Bump react-scripts from 3.4.1 to 4.0.3 + fix associated tech debt #1102

merged 38 commits into from
May 6, 2021

Commits on Apr 28, 2021

  1. npm install --save --save-exact react-scripts@4.0.3

    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    dbeb394 View commit details
    Browse the repository at this point in the history

  2. automatically added when running npm start

    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    c3bebe8 View commit details
    Browse the repository at this point in the history

  3. move public/icons/ -> src/assets/icons/ + fix references + remove unu… 

    …sed files
    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    613db96 View commit details
    Browse the repository at this point in the history

  4. move NavBar icons to src/assets/icons/ + fix references

    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    47e2a80 View commit details
    Browse the repository at this point in the history

  5. move various images/icons to src/assets/ + fix references

    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    39ee33f View commit details
    Browse the repository at this point in the history

  6. add @debt comment to de-duplicate DEFAULT_PROFILE_IMAGE, DEFAULT_AVAT… 

    …AR_IMAGE, DEFAULT_PROFILE_PIC
    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    b73bad0 View commit details
    Browse the repository at this point in the history

  7. remove eslint-config-react-app from package.json as create-react-app … 

    …already provides this
    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    57c39a4 View commit details
    Browse the repository at this point in the history

  8. remove additional eslint deps from package.json as create-react-app a… 

    …lready provides them
    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    8058e9e View commit details
    Browse the repository at this point in the history

  9. npm dedup

    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    031b1bd View commit details
    Browse the repository at this point in the history

  10. ensure our eslint config extends from react-app as create-react-app s… 

    …uggests
    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    4c651ef View commit details
    Browse the repository at this point in the history

  11. eslint: disable no-redeclare -> enable @typescript-eslint/no-redeclar… 

    …e": "warn",
    @0xdevalias
    0xdevalias committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    21ee8ff View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2021

  1. fix error 'T' is defined but never used @typescript-eslint/no-unused-… 

    …vars
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    54c93d2 View commit details
    Browse the repository at this point in the history

  2. fix 'checkUserIsOwner' was used before it was defined @typescript-esl… 

    …int/no-use-before-define
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    005ef3f View commit details
    Browse the repository at this point in the history

  3. fix 'dataOrUpdateKey' was used before it was defined @typescript-esli… 

    …nt/no-use-before-define
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    f8f8a92 View commit details
    Browse the repository at this point in the history

  4. fix error 'EditProfileFormValuesType' is defined but never used @type… 

    …script-eslint/no-unused-vars
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    b40e1f1 View commit details
    Browse the repository at this point in the history

  5. fix warning The 'menu' object makes the dependencies of useMemo Hook … 

    …(at line 292) change on every render.
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    671a759 View commit details
    Browse the repository at this point in the history

  6. fix error 'useFirestoreConnect' import from 'react-redux-firebase' is… 

    … restricted.
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    e1d585d View commit details
    Browse the repository at this point in the history

  7. fix error 'CSSProperties' is defined but never used @typescript-eslin… 

    …t/no-unused-vars
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    6f85a21 View commit details
    Browse the repository at this point in the history

  8. fix warning 'AdminVenuePreview' is already defined @typescript-eslint… 

    …/no-redeclare
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    12a2f11 View commit details
    Browse the repository at this point in the history

  9. fix warning 'RoomInnerForm' is already defined @typescript-eslint/no-… 

    …redeclare
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    72dd300 View commit details
    Browse the repository at this point in the history

  10. fix warning 'TextReactionType' is already defined @typescript-eslint/… 

    …no-redeclare
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    6dc8c12 View commit details
    Browse the repository at this point in the history

  11. cleanup

    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    3e3650f View commit details
    Browse the repository at this point in the history

  12. fix warning 'checkValidServiceWorker' / 'registerValidSW' was used be… 

    …fore it was defined @typescript-eslint/no-use-before-define
    @0xdevalias
    0xdevalias committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    2f9d57d View commit details
    Browse the repository at this point in the history

Commits on May 2, 2021

  1. refactor Audience to accept venue as a prop

    @0xdevalias
    0xdevalias committed May 2, 2021
    Configuration menu
    Copy the full SHA
    1096ad8 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2021

  1. improve maybeSelector / maybeArraySelector / emptyArraySelector

    @0xdevalias
    0xdevalias committed May 3, 2021
    Configuration menu
    Copy the full SHA
    673dcc8 View commit details
    Browse the repository at this point in the history

  2. refactor useConnectRelatedVenues functions to make better use of mayb… 

    …eArraySelector / etc improvements
    @0xdevalias
    0xdevalias committed May 3, 2021
    Configuration menu
    Copy the full SHA
    08aa0e1 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. fix warning The 'venueEvents' logical expression could make the depen… 

    …dencies of useMemo Hook (at line 68) change on every render.
    @0xdevalias
    0xdevalias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    7eba538 View commit details
    Browse the repository at this point in the history

  2. refactor Audience to use usePartygoersbySeat hook

    @0xdevalias
    0xdevalias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f7379d0 View commit details
    Browse the repository at this point in the history

  3. refactor Auditorium to extract takeSeat / leaveSeat from main memo

    @0xdevalias
    0xdevalias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    325aa1a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'staging' into devalias/deps-upgrade-react-scripts

    @0xdevalias
    0xdevalias authored May 4, 2021
    Configuration menu
    Copy the full SHA
    780250a View commit details
    Browse the repository at this point in the history

  5. fix Jest Validation Error: Directory <rootDir> in the rootDir option … 

    …was not found.
    @0xdevalias
    0xdevalias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    4a5b3af View commit details
    Browse the repository at this point in the history

  6. npm install --save-dev source-map-explorer

    @0xdevalias
    0xdevalias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    cae1c8a View commit details
    Browse the repository at this point in the history

  7. npm dedup

    @0xdevalias
    0xdevalias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    0640fc0 View commit details
    Browse the repository at this point in the history

  8. add source-map-explorer analyze script to package.json

    @0xdevalias
    0xdevalias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    3d343ab View commit details
    Browse the repository at this point in the history

  9. remove @babel/preset-typescript@7.12.7 as it comes in react-scripts

    @0xdevalias
    0xdevalias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    2cb8936 View commit details
    Browse the repository at this point in the history

  10. npm run browserslist:update-db

    @0xdevalias
    0xdevalias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1095327 View commit details
    Browse the repository at this point in the history

  11. add @debt comments for eslint rulesets to enable in future

    @0xdevalias
    0xdevalias committed May 4, 2021
    Configuration menu
    Copy the full SHA
    b143afa View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Merge remote-tracking branch 'origin/staging' into devalias/deps-upgr… 

    …ade-react-scripts
    @0xdevalias
    0xdevalias committed May 6, 2021
    Configuration menu
    Copy the full SHA
    e384d8f View commit details
    Browse the repository at this point in the history