Bump react-scripts from 3.4.1 to 4.0.3 + fix associated tech debt #1102

0xdevalias · 2021-01-25T03:08:10Z

Bumps react-scripts from 3.4.1 to 4.0.3.

Partially fixes sparkletown/internal-sparkle-issues#617

Partially fixes sparkletown/internal-sparkle-issues#645

Release Notes

https://github.com/facebook/create-react-app/releases/tag/v4.0.3
- v4.0.3 is a maintenance release that includes minor bug fixes and dependency updates.
https://github.com/facebook/create-react-app/releases/tag/v4.0.2
- v4.0.2 is a maintenance release that includes minor bug fixes and documentation updates.
https://github.com/facebook/create-react-app/releases/tag/v4.0.1
- v4.0.1 is a maintenance release that includes minor bug fixes and documentation updates.
https://github.com/facebook/create-react-app/releases/tag/v4.0.0
- Create React App 4.0 is a major release with several new features, including support for Fast Refresh!
- NOTE: You may need to delete your node_modules folder and reinstall your dependencies by running yarn (or npm install) if you encounter errors after upgrading.
- Highlights
  - Fast Refresh
  - React 17 support
    - New JSX transform
  - TypeScript 4 support
  - ESLint 7
    - New Jest and React Testing Library rules
  - Jest 26
  - PWA/workbox improvements
    - Switch to the Workbox InjectManifest plugin
    - Now its own template so it can be released independently
  - Web Vitals support
https://github.com/facebook/create-react-app/releases/tag/v3.4.4
- v3.4.4 release bumps resolve-url-loader to a version for which npm audit does not report a vulnerability. Note that this vulnerability did not affect Create React App
- projects, so this change is only necessary to satisfy auditing tools.
https://github.com/facebook/create-react-app/releases/tag/v3.4.3
- v3.4.3 release bumps terser-webpack-plugin to a version for which npm audit does not report a vulnerability. Note that this vulnerability did not affect Create React App projects, so this change is only necessary to satisfy auditing tools.
https://github.com/facebook/create-react-app/releases/tag/v3.4.2
- v3.4.2 release bumps webpack-dev-server to a version for which npm audit does not report a vulnerability. Note that this vulnerability did not affect Create React App projects, so this change is only necessary to satisfy auditing tools.

Notes

~~We will probably need to land this react-scripts update before we can upgrade node-sass in Bump node-sass from 4.14.1 to 5.0.0 #1079~~
- ~~see Bump node-sass from 4.14.1 to 5.0.0 #1079 (comment) / Replace deprecated node-sass dependency with sass #850~~
- Already handled: Replace deprecated node-sass dependency with dart-sass #1103
We probably want to disable the new JSX transform for now, as it can have incompatibilities with other tools, and probably warrants it's own standalone PR to enable
- https://create-react-app.dev/docs/advanced-configuration/
  - DISABLE_NEW_JSX_TRANSFORM=true

TODO

Rebase onto staging once Replace deprecated node-sass dependency with dart-sass #1103 has been merged
Will any of our eslint plugins/etc need to be updated for eslint 7.x?
Anything else?

codeclimate · 2021-01-25T03:08:46Z

Code Climate has analyzed commit e384d8f and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

codeclimate

The PR diff size of 16217 lines exceeds the maximum allowed for the inline comments feature.

0xdevalias · 2021-04-07T03:43:19Z

Note: react-scripts is up to v4.0.3 now, so when we come back back to this, we should make sure to target at least that version (or whatever is then the latest):

⇒  npm install --save --save-exact react-scripts@4.0.3

..snip..

+ react-scripts@4.0.3
added 946 packages from 247 contributors, removed 369 packages, updated 435 packages, moved 27 packages and audited 3404 packages in 77.858s

0xdevalias · 2021-04-28T04:50:41Z

Failed to compile.

./src/components/molecules/NavBar/NavBar.scss (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-6-1!./node_modules/postcss-loader/src??postcss!./node_modules/resolve-url-loader??ref--5-oneOf-6-3!./node_modules/sass-loader/dist/cjs.js??ref--5-oneOf-6-4!./src/components/molecules/NavBar/NavBar.scss)
Error: Can't resolve '../../../icons/sparkle-nav-logo.png' in '/Users/devalias/dev/sparkle/sparkle/src/components/molecules/NavBar'

Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870
- Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870 (comment)
- Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870 (comment)
- Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870 (comment)
  - It looks like this is caused by the css-loader migration to v4
  - Originally, a root-relative path like /foo/bar.ext would remain untouched, but as per css-loader@4 it becomes processed
- Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870 (comment)
  - If you care to dive into the react-scripts webpack setup, you can pass in the option to disable url routing to css-loader. In node_modules/react-scripts/config/webpack.config.js on line 121
- Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870 (comment)
  - Looking at css-loader it looks like they're not going to fix it: v4 tries to resolve the absolute urls in css files and gets an error. webpack-contrib/css-loader#1136 (comment)
  - You would have to include /public to the resolve paths. I just moved my assets to /src as I didn't want to eject
- Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870 (comment)
  - Here's a fix using react-app-rewired for css files with absolute links.
- Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870 (comment)
  - As developer of css-loader, I want to say that css-loader supports /images/image.png in url, CRA should add src to resolver.roots (and using /images/image.png will be resolved as /src/images/image.png, it is default behavior for webpack@5)
- Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870 (comment)
  - I moved svg, png, jpg and font files from /public to /src and referenced them in jsx/scss/css files as recommended here:
- Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870 (comment)
  - Just note, the latest version of css-loader supports /* webpackIgnore: true */, i.e. you can write
- Compilation error with react-scripts 4.0.0 ( Can't resolve file ) facebook/create-react-app#9870 (comment)
  - Moving assets (at least those read by css-loader) from public to src is not a big deal and is the "recommended way" of Adding Images, Fonts, and Files as stated in the CRA documentation: create-react-app.dev/docs/adding-images-fonts-and-files

…sed files

…AR_IMAGE, DEFAULT_PROFILE_PIC

0xdevalias · 2021-04-28T06:29:19Z

Starting the development server...

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=3.3.1 <3.10.0

YOUR TYPESCRIPT VERSION: 4.2.4

Please only submit bug reports when using the officially supported version.

=============

Currently on: https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/CHANGELOG.md#371-2020-07-27

https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/CHANGELOG.md#400-2020-08-31
- Breaking Changes
- https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.0.0
https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/CHANGELOG.md#4160-2021-03-01
- 4.16.0 (2021-03-01)
- TypeScript 4.2 syntax support (Bump firebase from 8.8.0 to 9.13.0 in /functions #3112) (2ebfb21)

Latest seems to be 4.22.0 at the moment:

https://github.com/typescript-eslint/typescript-eslint/releases
- https://github.com/typescript-eslint/typescript-eslint/releases/tag/v4.22.0

Looks like react-scripts provides this dependency for us:

⇒  npm ls @typescript-eslint/eslint-plugin
co-reality-map@0.1.0 /Users/devalias/dev/sparkle/sparkle
├── @typescript-eslint/eslint-plugin@3.7.1
└─┬ react-scripts@4.0.3
  └── @typescript-eslint/eslint-plugin@4.22.0

⇒  npm ls @typescript-eslint/parser
co-reality-map@0.1.0 /Users/devalias/dev/sparkle/sparkle
├── @typescript-eslint/parser@3.7.1
└─┬ react-scripts@4.0.3
  └── @typescript-eslint/parser@4.22.0

https://github.com/facebook/create-react-app/tree/v4.0.3/packages/eslint-config-react-app#usage-in-create-react-app-projects
- The easiest way to use this configuration is with Create React App, which includes it by default.
- You don’t need to install it separately in Create React App projects.

I tried explicitly removing the dependencies from our package files to use the version it supposedly includes by default, but I was getting all sorts of errors/issues.

There used to be a EXTEND_ESLINT env var in create react app, but since v4 they removed it as apparently it's not needed anymore:

https://create-react-app.dev/docs/setting-up-your-editor/#extending-or-replacing-the-default-eslint-config

There seems to be more confusion in this thread about it all as well:

[eslint-config-react-app] Recommended way of config integration with ESLint, TypeScript, Prettier and VS Code facebook/create-react-app#8849

This even spun out a website to attempt to tell people how they can set everything up:

https://eslintconfig.dev/
- https://eslintconfig.dev/cra/typescript-prettier

Yet when I try and use that config without having any additional dependencies installed directly within our own package.json file, it fails with the following:

⇒  npx eslint --print-config src/index.tsx

Oops! Something went wrong! :(

ESLint: 7.25.0

ESLint couldn't find the config "react-app" to extend from. Please check that the name of the config is correct.

The config "react-app" was referenced from the config file in "/Users/devalias/dev/sparkle/sparkle/.eslintrc.js".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

Based on facebook/create-react-app#9083 (comment) I tried deleting the entire package-lock.json file and 'starting from scratch' locally to see if it would work, and it seems like it did:

⇒  npx eslint --print-config src/index.tsx
{
  "env": {
    "browser": true,
    "commonjs": true,
    "es6": true,
    "jest": true,
    "node": true
  },
  "globals": {},
  "parser": "/Users/devalias/dev/sparkle/sparkle/node_modules/@typescript-eslint/parser/dist/index.js",
  "parserOptions": {
   // ..snip..

So I guess the next question is how can we 'clean up' the existing package-lock.json file so it doesn't have any issues..?

…already provides this

…lready provides them

0xdevalias

[note] Some notes to explain various aspects of this PR to make reviewing easier.

Note also that the mass of changes to package-lock.diff are due to react-scripts (and all of the dependencies it wraps up) changing version (as we intended), as can be seen in dbeb394

functions/venue.js

package.json

src/components/organisms/ProfileModal/EditProfileForm/EditProfileForm.tsx

src/hooks/useFirestoreConnect.ts

src/serviceWorker.js

tsconfig.json

package.json

0xdevalias · 2021-05-04T04:51:24Z

Before

⇒  npm i
npm WARN eslint-config-react-app@5.2.1 requires a peer of @typescript-eslint/eslint-plugin@2.x but none is installed. You must install peer dependencies yourself.
npm WARN eslint-config-react-app@5.2.1 requires a peer of @typescript-eslint/parser@2.x but none is installed. You must install peer dependencies yourself.
npm WARN eslint-config-react-app@5.2.1 requires a peer of eslint-plugin-react-hooks@1.x || 2.x but none is installed. You must install peer dependencies yourself.
npm WARN The package @types/styled-components is included as both a dev and production dependency.

audited 2827 packages in 9.807s

91 packages are looking for funding
  run `npm fund` for details

found 5137 vulnerabilities (5097 low, 5 moderate, 35 high)
  run `npm audit fix` to fix them, or `npm audit` for details

⇒  npm run build

> co-reality-map@0.1.0 build /Users/devalias/dev/sparkle/sparkle
> react-scripts build

Creating an optimized production build...
Compiled successfully.

File sizes after gzip:

  628.17 KB  build/static/js/2.2a99c644.chunk.js
  107.98 KB  build/static/js/main.2df18998.chunk.js
  97.27 KB   build/static/css/main.aade0aa4.chunk.css
  9.45 KB    build/static/js/3.c0da807d.chunk.js
  1.17 KB    build/static/js/runtime-main.d2e9ab6b.js

After

⇒  npm i
npm WARN @babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining@7.13.12 requires a peer of @babel/core@^7.13.0 but none is installed. You must install peer dependencies yourself.
npm WARN The package @types/styled-components is included as both a dev and production dependency.

audited 3319 packages in 11.484s

166 packages are looking for funding
  run `npm fund` for details

found 471 vulnerabilities (434 low, 1 moderate, 36 high)
  run `npm audit fix` to fix them, or `npm audit` for details

⇒  npm run build

> co-reality-map@0.1.0 build /Users/devalias/dev/sparkle/sparkle
> react-scripts build

Creating an optimized production build...
Compiled successfully.

File sizes after gzip:

  630.06 KB  build/static/js/2.d00b77b8.chunk.js
  130.2 KB   build/static/css/main.9b7a5c6f.chunk.css
  117.31 KB  build/static/js/main.44653ba0.chunk.js
  9.49 KB    build/static/js/3.1e276629.chunk.js
  1.17 KB    build/static/js/runtime-main.d0e24706.js

Note: I believe the slight increase in size shown in this bundle is due to moving some of the image assets from public/ (where they won't have been reported in this bundle size) to being properly included as part of the bundle (using the recommended/best practice method of 'importing' the image files in the code, rather than referencing them with 'magic strings')

0xdevalias · 2021-05-04T06:19:32Z

https://create-react-app.dev/docs/supported-browsers-features/

Note that this project includes no polyfills by default.

If you use any other ES6+ features that need runtime support (such as Array.from() or Symbol), make sure you are including the appropriate polyfills manually, or that the browsers you are targeting already support them.

https://create-react-app.dev/docs/supported-browsers-features/#configuring-supported-browsers

The browserslist configuration controls the outputted JavaScript so that the emitted code will be compatible with the browsers specified. The production list will be used when creating a production build by running the build script, and the development list will be used when running the start script. You can use https://browserl.ist to see the browsers supported by your configured browserslist.

Note that this does not include polyfills automatically for you. You will still need to polyfill language features (see above) as needed based on the browsers you are supporting.

https://github.com/facebook/create-react-app/blob/master/packages/react-app-polyfill/README.md

This package includes polyfills for various browsers. It includes minimum requirements and commonly used language features used by Create React App projects.

https://github.com/facebook/create-react-app/blob/master/packages/react-app-polyfill/README.md#polyfilling-other-language-features

You can also polyfill stable language features not available in your target browsers. If you're using this in Create React App, it will automatically use the browserslist you've defined to only include polyfills needed by your target browsers when importing the stable polyfill. Make sure to follow the Internet Explorer steps above if you need to support Internet Explorer in your application.
// This must be the first line in src/index.js
import 'react-app-polyfill/stable';
If you are supporting Internet Explorer 9 or Internet Explorer 11 you should include both the ie9 or ie11 and stable modules:
// These must be the first lines in src/index.js
import 'react-app-polyfill/ie11';
import 'react-app-polyfill/stable';

We seem to already have this via react-scripts:

⇒  npm ls react-app-polyfill
co-reality-map@0.1.0 /Users/devalias/dev/sparkle/sparkle
└─┬ react-scripts@4.0.3
  └── react-app-polyfill@2.0.0

https://github.com/sparkletown/sparkle/blob/staging/src/polyfills.ts

https://babeljs.io/docs/en/babel-preset-env.html

@babel/preset-env is a smart preset that allows you to use the latest JavaScript without needing to micromanage which syntax transforms (and optionally, browser polyfills) are needed by your target environment(s). This both makes your life easier and JavaScript bundles smaller!

This seems to already be included via react-scripts -> babel-preset-react-app:

⇒  npm ls @babel/preset-env

co-reality-map@0.1.0 /Users/devalias/dev/sparkle/sparkle
└─┬ react-scripts@4.0.3
  ├─┬ @svgr/webpack@5.5.0
  │ └── @babel/preset-env@7.13.15
  ├─┬ babel-preset-react-app@10.0.0
  │ └── @babel/preset-env@7.12.1
  └─┬ workbox-webpack-plugin@5.1.4
    └─┬ workbox-build@5.1.4
      └── @babel/preset-env@7.13.15  deduped

https://babeljs.io/docs/en/babel-preset-env.html#bugfixes

Note: These optimizations will be enabled by default in Babel 8

By default, @babel/preset-env (and Babel plugins in general) grouped ECMAScript syntax features into collections of closely related smaller features. These groups can be large and include a lot of edge cases, for example "function arguments" includes destructured, default and rest parameters. From this grouping information, Babel enables or disables each group based on the browser support target you specify to @babel/preset-env’s targets option.

When this option is enabled, @babel/preset-env tries to compile the broken syntax to the closest non-broken modern syntax supported by your target browsers. Depending on your targets and on how many modern syntax you are using, this can lead to a significant size reduction in the compiled app. This option merges the features of @babel/preset-modules without having to use another preset.

https://babeljs.io/docs/en/babel-preset-env.html#usebuiltins

This option configures how @babel/preset-env handles polyfills.

When either the usage or entry options are used, @babel/preset-env will add direct references to core-js modules as bare imports (or requires). This means core-js will be resolved relative to the file itself and needs to be accessible.

Since @babel/polyfill was deprecated in 7.4.0, we recommend directly adding core-js and setting the version via the corejs option.

https://babeljs.io/docs/en/babel-preset-env.html#corejs

This option only has an effect when used alongside useBuiltIns: usage or useBuiltIns: entry, and ensures @babel/preset-env injects the polyfills supported by your core-js version. It is recommended to specify the minor version otherwise "3" will be interpreted as "3.0" which may not include polyfills for the latest features.

By default, only polyfills for stable ECMAScript features are injected: if you want to polyfill proposals, you have three different options:

mike-lvov

A few notes/questions

mike-lvov · 2021-05-05T20:28:44Z

src/components/molecules/NavSearchBar/NavSearchBar.tsx

  const clearSearchIcon = (
    <img
      className="NavSearchBar__clear-search"
-      src={CloseIcon}
+      src={navDropdownCloseIcon}
      alt="close button"
      onClick={clearSearchQuery}
    />


Wouldn't it be nicer to remove it & use font awesome instead?

Potentially, though @mcflyok tends not to like the font awesome iconography in general I believe.

This was just renaming the variable name of existing code, not intending to change logic in this PR.

mike-lvov · 2021-05-05T20:30:08Z

src/components/templates/Audience/Audience.tsx

-      takeSeat(null, null);
-    };
+  const leaveSeat = useCallback(() => {
+    takeSeat(null, null);


I guess we use null here because the implementation with undefined is not merged?

Where is the implementation with undefined out of curiosity?

I didn't seek to change any of the existing functionality in this PR, so I left it as what it was.

…ade-react-scripts

0xdevalias

Looks good to me (let's see if this satisfies the CODEOWNERS rule for @sparkletown/engineering-leads)

Edit: Seemingly it doesn't, and is a long outstanding issue: https://git.luolix.topmunity/t/do-not-require-owner-approval-if-the-pull-request-is-from-an-owner/369/64

Temporarily disabled the 'require CODEOWNERS' branch protection to get around this.

0xdevalias self-assigned this Jan 25, 2021

0xdevalias requested a deployment to feature-preview January 25, 2021 03:08 Waiting

github-actions bot added the dependencies Pull requests that update a dependency file label Jan 25, 2021

codeclimate bot reviewed Jan 25, 2021

View reviewed changes

0xdevalias requested a deployment to feature-preview January 25, 2021 03:15 Waiting

0xdevalias requested a deployment to feature-preview January 25, 2021 03:17 Waiting

0xdevalias requested a deployment to feature-preview January 25, 2021 03:19 Waiting

0xdevalias requested a deployment to feature-preview January 25, 2021 04:07 Waiting

0xdevalias requested a deployment to feature-preview January 25, 2021 04:08 Waiting

0xdevalias mentioned this pull request Apr 13, 2021

Bump typescript from 3.9.3 to 4.2.4 #1320

Merged

0xdevalias changed the title ~~Bump react-scripts from 3.4.1 to 4.0.1~~ Bump react-scripts from 3.4.1 to 4.0.3 Apr 28, 2021

npm install --save --save-exact react-scripts@4.0.3

dbeb394

0xdevalias force-pushed the devalias/deps-upgrade-react-scripts branch from beccf47 to dbeb394 Compare April 28, 2021 04:21

0xdevalias had a problem deploying to feature-preview April 28, 2021 04:21 Failure

automatically added when running npm start

c3bebe8

0xdevalias had a problem deploying to feature-preview April 28, 2021 04:30 Failure

0xdevalias added 4 commits April 28, 2021 15:18

move public/icons/ -> src/assets/icons/ + fix references + remove unu…

613db96

…sed files

move NavBar icons to src/assets/icons/ + fix references

47e2a80

move various images/icons to src/assets/ + fix references

39ee33f

add @debt comment to de-duplicate DEFAULT_PROFILE_IMAGE, DEFAULT_AVAT…

b73bad0

…AR_IMAGE, DEFAULT_PROFILE_PIC

0xdevalias had a problem deploying to feature-preview April 28, 2021 05:45 Failure

github-actions bot added the 💎 styles For (S)CSS style related issues/changes/improvements/etc. label Apr 28, 2021

0xdevalias added 2 commits April 28, 2021 16:34

remove eslint-config-react-app from package.json as create-react-app …

57c39a4

…already provides this

remove additional eslint deps from package.json as create-react-app a…

8058e9e

…lready provides them

0xdevalias temporarily deployed to feature-preview May 4, 2021 04:03 Inactive

0xdevalias changed the title ~~Bump react-scripts from 3.4.1 to 4.0.3~~ Bump react-scripts from 3.4.1 to 4.0.3 + fix associated tech debt May 4, 2021

0xdevalias marked this pull request as ready for review May 4, 2021 04:09

0xdevalias requested review from a team as code owners May 4, 2021 04:09

0xdevalias added the 💥 tech-debt label May 4, 2021

0xdevalias commented May 4, 2021

View reviewed changes

0xdevalias added 3 commits May 4, 2021 14:44

npm install --save-dev source-map-explorer

cae1c8a

npm dedup

0640fc0

add source-map-explorer analyze script to package.json

3d343ab

0xdevalias added 2 commits May 4, 2021 15:47

remove @babel/preset-typescript@7.12.7 as it comes in react-scripts

2cb8936

npm run browserslist:update-db

1095327

0xdevalias temporarily deployed to feature-preview May 4, 2021 06:19 Inactive

0xdevalias had a problem deploying to feature-preview May 4, 2021 06:54 Failure

0xdevalias force-pushed the devalias/deps-upgrade-react-scripts branch from cb80ed4 to 1d578f2 Compare May 4, 2021 07:15

0xdevalias had a problem deploying to feature-preview May 4, 2021 07:15 Failure

add @debt comments for eslint rulesets to enable in future

b143afa

0xdevalias force-pushed the devalias/deps-upgrade-react-scripts branch from 1d578f2 to b143afa Compare May 4, 2021 07:22

0xdevalias temporarily deployed to feature-preview May 4, 2021 07:22 Inactive

0xdevalias added the 💻 eng-QoL Engineering Quality of Life (QoL). Scripts, bots, automations, etc; that ensure our standards label May 4, 2021

mike-lvov approved these changes May 5, 2021

View reviewed changes

Merge remote-tracking branch 'origin/staging' into devalias/deps-upgr…

e384d8f

…ade-react-scripts

0xdevalias temporarily deployed to feature-preview May 6, 2021 07:21 Inactive

0xdevalias commented May 6, 2021

View reviewed changes

0xdevalias removed the request for review from a team May 6, 2021 07:29

0xdevalias merged commit 5b6d4a0 into staging May 6, 2021

0xdevalias deleted the devalias/deps-upgrade-react-scripts branch May 6, 2021 07:31

mike-lvov mentioned this pull request May 6, 2021

deploy staging -> master #1365

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump react-scripts from 3.4.1 to 4.0.3 + fix associated tech debt #1102

Bump react-scripts from 3.4.1 to 4.0.3 + fix associated tech debt #1102

0xdevalias commented Jan 25, 2021 •

edited

Loading

codeclimate bot commented Jan 25, 2021 •

edited

Loading

codeclimate bot left a comment

0xdevalias commented Apr 7, 2021 •

edited

Loading

0xdevalias commented Apr 28, 2021

0xdevalias commented Apr 28, 2021 •

edited

Loading

0xdevalias left a comment •

edited

Loading

0xdevalias commented May 4, 2021

0xdevalias commented May 4, 2021

mike-lvov left a comment

mike-lvov May 5, 2021

0xdevalias May 6, 2021

mike-lvov May 5, 2021

0xdevalias May 6, 2021 •

edited

Loading

0xdevalias left a comment •

edited

Loading

Bump react-scripts from 3.4.1 to 4.0.3 + fix associated tech debt #1102

Bump react-scripts from 3.4.1 to 4.0.3 + fix associated tech debt #1102

Conversation

0xdevalias commented Jan 25, 2021 • edited Loading

Release Notes

Notes

TODO

codeclimate bot commented Jan 25, 2021 • edited Loading

codeclimate bot left a comment

Choose a reason for hiding this comment

0xdevalias commented Apr 7, 2021 • edited Loading

0xdevalias commented Apr 28, 2021

0xdevalias commented Apr 28, 2021 • edited Loading

0xdevalias left a comment • edited Loading

Choose a reason for hiding this comment

0xdevalias commented May 4, 2021

Before

After

0xdevalias commented May 4, 2021

mike-lvov left a comment

Choose a reason for hiding this comment

mike-lvov May 5, 2021

Choose a reason for hiding this comment

0xdevalias May 6, 2021

Choose a reason for hiding this comment

mike-lvov May 5, 2021

Choose a reason for hiding this comment

0xdevalias May 6, 2021 • edited Loading

Choose a reason for hiding this comment

0xdevalias left a comment • edited Loading

Choose a reason for hiding this comment

0xdevalias commented Jan 25, 2021 •

edited

Loading

codeclimate bot commented Jan 25, 2021 •

edited

Loading

0xdevalias commented Apr 7, 2021 •

edited

Loading

0xdevalias commented Apr 28, 2021 •

edited

Loading

0xdevalias left a comment •

edited

Loading

0xdevalias May 6, 2021 •

edited

Loading

0xdevalias left a comment •

edited

Loading