Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy staging -> master #1365

Merged
merged 1 commit into from
May 6, 2021
Merged

deploy staging -> master #1365

merged 1 commit into from
May 6, 2021

Conversation

mike-lvov
Copy link
Contributor

Deploys:

)

* npm install --save --save-exact react-scripts@4.0.3
* automatically added when running npm start
* move public/icons/ -> src/assets/icons/ + fix references + remove unused files
* move NavBar icons to src/assets/icons/ + fix references
* move various images/icons to src/assets/ + fix references
* add @debt comment to de-duplicate DEFAULT_PROFILE_IMAGE, DEFAULT_AVATAR_IMAGE, DEFAULT_PROFILE_PIC
* remove eslint-config-react-app from package.json as create-react-app already provides this
* remove additional eslint deps from package.json as create-react-app already provides them
* npm dedup
* ensure our eslint config extends from react-app as create-react-app suggests
* eslint: disable no-redeclare -> enable @typescript-eslint/no-redeclare": "warn",
* fix error  'T' is defined but never used  @typescript-eslint/no-unused-vars
* fix 'checkUserIsOwner' was used before it was defined  @typescript-eslint/no-use-before-define
* fix 'dataOrUpdateKey' was used before it was defined  @typescript-eslint/no-use-before-define
* fix error  'EditProfileFormValuesType' is defined but never used  @typescript-eslint/no-unused-vars
* fix warning  The 'menu' object makes the dependencies of useMemo Hook (at line 292) change on every render.
* fix  error  'useFirestoreConnect' import from 'react-redux-firebase' is restricted.
* fix error  'CSSProperties' is defined but never used  @typescript-eslint/no-unused-vars
* fix warning  'AdminVenuePreview' is already defined  @typescript-eslint/no-redeclare
* fix warning  'RoomInnerForm' is already defined  @typescript-eslint/no-redeclare
* fix warning  'TextReactionType' is already defined  @typescript-eslint/no-redeclare
* fix warning  'checkValidServiceWorker' / 'registerValidSW' was used before it was defined  @typescript-eslint/no-use-before-define
* refactor Audience to accept venue as a prop
* improve maybeSelector / maybeArraySelector / emptyArraySelector
* refactor useConnectRelatedVenues functions to make better use of maybeArraySelector / etc improvements
* fix warning  The 'venueEvents' logical expression could make the dependencies of useMemo Hook (at line 68) change on every render.
* refactor Audience to use usePartygoersbySeat hook
* refactor Auditorium to extract takeSeat / leaveSeat from main memo
* fix Jest Validation Error: Directory <rootDir> in the rootDir option was not found.
* npm install --save-dev source-map-explorer
* npm dedup
* add source-map-explorer analyze script to package.json
* remove @babel/preset-typescript@7.12.7 as it comes in react-scripts
* npm run browserslist:update-db
* add @debt comments for eslint rulesets to enable in future
@mike-lvov mike-lvov added the 🚀 deployment For PRs that are deploying to production label May 6, 2021
@mike-lvov mike-lvov requested a review from a team May 6, 2021 18:14
@mike-lvov mike-lvov self-assigned this May 6, 2021
@mike-lvov mike-lvov requested a review from a team as a code owner May 6, 2021 18:14
@github-actions github-actions bot added dependencies Pull requests that update a dependency file 💎 styles For (S)CSS style related issues/changes/improvements/etc. labels May 6, 2021
@mike-lvov mike-lvov merged commit 7987bab into master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file 🚀 deployment For PRs that are deploying to production 💎 styles For (S)CSS style related issues/changes/improvements/etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants