Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated node-sass dependency with dart-sass #1103

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

0xdevalias
Copy link
Contributor

@0xdevalias 0xdevalias commented Jan 25, 2021

fixes #850


From #850:


Since we already seem to be using a version of saas-loader that supports the non-deprecated dart-sass, and because create-react-app's react-scripts doesn't seem to support node-sass v5 yet (targeted for 4.0.2 milestone), I think our best way forward here is to switch to using dart-sass instead of this.

Originally posted by @0xdevalias in #1079 (comment)

@0xdevalias 0xdevalias self-assigned this Jan 25, 2021
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 25, 2021
@0xdevalias 0xdevalias requested a review from a team January 25, 2021 03:45
@codeclimate
Copy link

codeclimate bot commented Jan 27, 2021

Code Climate has analyzed commit 6f4a7ee and detected 0 issues on this pull request.

View more on Code Climate.

@0xdevalias 0xdevalias merged commit 9e6ab9b into staging Jan 27, 2021
@0xdevalias 0xdevalias deleted the devalias/deps-replace-node-sass-with-dart-sass branch January 27, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated node-sass dependency with sass
2 participants