Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force docutils <0.13.1 #77

Merged
merged 1 commit into from
Dec 11, 2016
Merged

Conversation

SylvainCorlay
Copy link
Contributor

Docutils 0.13.1 which was just released breaks nbsphinx because of sphinx-doc/sphinx#3212

The issue seems to have been fixed in sphinx master since sphinx-doc/sphinx#3217 but until a new version of sphinx is released, we need to force docutils<0.13.1.

@SylvainCorlay SylvainCorlay changed the title Force docutils 0.13.1 Force docutils <0.13.1 Dec 11, 2016
@mgeier
Copy link
Member

mgeier commented Dec 11, 2016

Would the long-term solution (after a few new Sphinx releases) be to force sphinx>=1.5.1 and remove the limitation on docutils?

@mgeier
Copy link
Member

mgeier commented Dec 11, 2016

Note that there is a bug in sphinx-doc/sphinx#3217, see sphinx-doc/sphinx#3217 (comment).

@mgeier
Copy link
Member

mgeier commented Dec 11, 2016

Would it work if we (after the release of Sphinx 1.5.1) use sphinx!=1.5?

There is another breaking change (see #78) which will hopefully be fixed in sphinx-doc/sphinx#3224.

@SylvainCorlay
Copy link
Contributor Author

Would the long-term solution (after a few new Sphinx releases) be to force sphinx>=1.5.1 and remove the limitation on docutils?

That is right, but in the mean time, the current setup breaks RTD builds with sphinx.

@SylvainCorlay
Copy link
Contributor Author

Would it work if we (after the release of Sphinx 1.5.1) use sphinx!=1.5?

No idea :)

@mgeier mgeier merged commit 057ad47 into spatialaudio:master Dec 11, 2016
mgeier added a commit that referenced this pull request Dec 11, 2016
@mgeier
Copy link
Member

mgeier commented Dec 11, 2016

I'll undo this in #79. If there are objections, please comment there.

@mpacer
Copy link

mpacer commented Dec 15, 2016

Sphinx 1.5.1 doesn't include the fix, it won't be available until Sphinx 1.5.2.

@mgeier
Copy link
Member

mgeier commented Dec 16, 2016

@michaelpacer Are you talking about sphinx-doc/sphinx#3217 not being available in Sphinx 1.5.1?

Or rather about sphinx-doc/sphinx#3224?

@mpacer
Copy link

mpacer commented Dec 16, 2016 via email

@mgeier
Copy link
Member

mgeier commented Dec 16, 2016

Thanks for the clarification.

AFAIK, the two issues are not related, they just happened to break at the same Sphinx version.

The first one should be resolved in Sphinx 1.5.1, the second one will hopefully be fixed with #85.

mgeier added a commit that referenced this pull request Dec 17, 2016
mgeier added a commit that referenced this pull request Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants