Fix #3212: HTML Builders crashes with docutils-0.13 #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
commented
Dec 10, 2016
| @@ -15,8 +15,8 @@ env: | |||
| - PYTHONFAULTHANDLER=x | |||
| - PYTHONWARNINGS=all | |||
| matrix: | |||
| - DOCUTILS=0.11 | |||
There was a problem hiding this comment.
At this PR, I removed docutils-0.11 from test matrix to prevent to increase test time.
@shimizukawa what do you think?
There was a problem hiding this comment.
It's OK to me.
IMO, it is sufficient to keep only the last two versions.
This was referenced Dec 10, 2016
mgeier
reviewed
Dec 11, 2016
| @@ -532,6 +533,16 @@ def visit_image(self, node): | |||
| node['height'] = str(size[1]) | |||
| BaseTranslator.visit_image(self, node) | |||
|
|
|||
| # overwritten | |||
| def depart_image(self, node): | |||
| if docutils.__version__ >= "0.13": | |||
There was a problem hiding this comment.
This comparison doesn't always work:
>>> '0.9' >= '0.13'
TrueThere was a problem hiding this comment.
Good point. I post a new PR for this: #3225.
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Dec 11, 2016
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Dec 12, 2016
tk0miya
added a commit
that referenced
this pull request
Dec 12, 2016
Fix version comparison (refs: #3217)
return42
referenced
this pull request
in return42/linuxdoc
Oct 17, 2018
BTW: add pylint *disables* for handled *deprecation* warnings Bugfixes: - Sphinx <= 1.4 (bug in docutils >= 0.13) : HTML Builders crashes with docutils-0.13 `[ref] <https://github.com/sphinx-doc/sphinx/pull/3217>`__ Downward compatibility: - Sphinx >= 1.6: ``Sphinx.warn()``, ``Sphinx.info()`` and other logging methods are now deprecated. Please use ``sphinx.util.logging`` instead. It will be removed in Sphinx-2.0. - Sphinx >= 1.7: ``sphinx.ext.autodoc.AutodocReporter`` is replaced by ``sphinx.util.docutils. switch_source_input()`` and now deprecated. It will be removed in Sphinx-2.0. Signed-off-by: Markus Heiser <markus.heiser@darmarit.de>
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #3212.